Comments (5)
which mad instruction(GCN ISA/fma)? what are you trying to run? Can you provide a sample? What behavior were you expecting?
from clr.
@cjatin
on RDNA
v_mad_u64_u32, why doesn't it carry in
?
for example:
a1, c1(carry out) = b1 + d1 +c0(carry in)
a2, c2(carry out) = b2 + d2 + c1(carry in)
from clr.
not a hip issue
from clr.
this issue is better raised against amdgpu backend on llvm-project github https://github.com/llvm/llvm-project/issues in the hope that the hardware limitation may be reported to right channel.
Based on ISA manual
the instruction does not have carry in. this may be a design decision due to cost/performance balance. since support carry in with mad will increase its footage on chip design, but you can still use add/multiply to handle need for carry in.
how much performance gain can be achieved if there is carry in in mad instruction?
from clr.
this issue is better raised against amdgpu backend on llvm-project github https://github.com/llvm/llvm-project/issues in the hope that the hardware limitation may be reported to right channel.
Based on ISA manual
the instruction does not have carry in. this may be a design decision due to cost/performance balance. since support carry in with mad will increase its footage on chip design, but you can still use add/multiply to handle need for carry in.
how much performance gain can be achieved if there is carry in in mad instruction?
For big integer multiply.
If I use the current instruction, I need mad
-> add
-> mad
-> ... it is 6 clk for single operation
but if mad instruction have carry in, I only need mad
->mad
-> ... it is only 4 clk for single operation
I can gain at least 50% performance improvement.
from clr.
Related Issues (20)
- [Issue]: hip-5.7.1 failed tests: invalid device pointer Code 17 with hipIpcOpenMemHandle( , , hipIpcMemLazyEnablePeerAccess) HOT 4
- [Issue]: libamdocl64.so causes segfault
- [Issue]: hip-config-amd.cmake choked when there is no CXX compiler HOT 2
- [Issue/clr]: clEnqueueReleaseD3D11ObjectsKHR returned CL_INVALID_GL_OBJECT HOT 15
- [Issue]: CO lookup in fatbin should only fail when none of the GPUs have matching CO HOT 2
- [Issue]: warning clangrt builtins lib not found when CXX doesn't exist HOT 2
- [Issue]: gfx900 *ERROR* ring page0 timeout HOT 1
- [QA] error: use of undeclared identifier '__asm__' HOT 1
- [Feature]: Run kernel with cooperative thread blocks and performance measurement ability HOT 1
- [Issue]: clr-rocm-6.0.2/rocclr/os/os_posix.cpp:321: static void amd::Os::currentStackInfo(unsigned char**, size_t*): Assertion `Os::currentStackPtr() >= *base - *size && Os::currentStackPtr() < *base && "just checking"' failed. HOT 3
- Build fails with strict-aliasing violations HOT 1
- dispatchGenericAqlPacket,If the size parameter in the function is not equal to 1, there may be problems. HOT 3
- OpenCL Performance: way to extract parallel kernel execution with out-of-order command queue HOT 3
- Update AMD_PLATFORM_BUILD_NUMBER
- [Issue]: `roc::NullDevice::importExtSemaphore` (`hipImportExternalSemaphore`) crash
- [Issue]: ROCM5.7.3, RCCL2.19.4 GPU kernel can't printf。Hash value collision detected HOT 3
- [Issue]: standard math operations on vector types fail to build with GNU g++ HOT 2
- [Issue]: Simplest offline compiled saxpy kernel fails to load on gfx90c HOT 3
- [Issue]: No performance improvement using hipGraph HOT 1
- [Issue]: hipMemcpyWithStream causes severe stall in Hugginface Transformers LLM generation with Pytorch HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clr.