Comments (3)
@roderickhsiao yeah, thanks for your quick response. I switched further to terser plugin and now have everything working nicely. 👍
from react-aspect-ratio.
Thanks for reaching out
Several issues I could see
1 UglifyJs
won't work for es module, suggested to use terser, which is a fork of uglify-es (not maintained) - and break lots of React bundling
, webpack already move away default minifier to terser
instead.
- you could try to alias
react-aspect-ratio/es
toreact-aspect-ratio
in webpack, which will load the cjs bundle instead of es bundle - You can also include this library in your webpack file so it can be transpile via babel alone with your application code before minify the code.
Hope it helps
from react-aspect-ratio.
Yes, there is a huge discussion in open source community as many people found issues on uglify
and uglify-es
(even babel-minifiy
), and currently the safest way is just switch to terser
from react-aspect-ratio.
Related Issues (20)
- is there any typescript version of this package is available ?? HOT 2
- An in-range update of eslint-plugin-import is breaking the build 🚨 HOT 10
- An in-range update of eslint-plugin-flowtype is breaking the build 🚨 HOT 22
- An in-range update of babel-loader is breaking the build 🚨 HOT 1
- An in-range update of storybook is breaking the build 🚨 HOT 42
- An in-range update of eslint-plugin-react is breaking the build 🚨 HOT 10
- An in-range update of eslint-plugin-jsx-a11y is breaking the build 🚨 HOT 2
- An in-range update of babel7 is breaking the build 🚨 HOT 45
- An in-range update of storybook-addon-jsx is breaking the build 🚨 HOT 10
- An in-range update of react is breaking the build 🚨 HOT 6
- An in-range update of storybook is breaking the build 🚨 HOT 6
- nextRatio is undefined HOT 1
- Support for npm v6 HOT 2
- aspect-ratio.css may get optimised away by webpack HOT 1
- Can't resolve 'react-aspect-ratio' HOT 5
- Images still popping in after aspect-ratio set. HOT 11
- add support for tyepscript HOT 2
- Not working at all? HOT 4
- How to do central alignment? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-aspect-ratio.