GithubHelp home page GithubHelp logo

Comments (3)

karolisgrinkevicius avatar karolisgrinkevicius commented on May 14, 2024 1

@roderickhsiao yeah, thanks for your quick response. I switched further to terser plugin and now have everything working nicely. 👍

from react-aspect-ratio.

roderickhsiao avatar roderickhsiao commented on May 14, 2024

Thanks for reaching out

Several issues I could see

1 UglifyJs won't work for es module, suggested to use terser, which is a fork of uglify-es (not maintained) - and break lots of React bundling, webpack already move away default minifier to terser instead.

  1. you could try to alias react-aspect-ratio/es to react-aspect-ratio in webpack, which will load the cjs bundle instead of es bundle
  2. You can also include this library in your webpack file so it can be transpile via babel alone with your application code before minify the code.

Hope it helps

from react-aspect-ratio.

roderickhsiao avatar roderickhsiao commented on May 14, 2024

Yes, there is a huge discussion in open source community as many people found issues on uglify and uglify-es (even babel-minifiy), and currently the safest way is just switch to terser

from react-aspect-ratio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.