support node 10.4 about node-gtk

[romgrk]

Yes, currently only tested with 8.x.
Issues with 10.x are caused by the removal of V8's object->ForceSet(), which is still used in [email protected].
nodejs/nan#763

[romgrk]

nodejs/nan#763 (comment)

Which is true #if NODE_MODULE_VERSION >= NODE_9_0_MODULE_VERSION:
https://github.com/nodejs/nan/blob/master/nan_maybe_43_inl.h#L137-L144

Not sure where it's coming from yet. (Btw, I'm assuming you get the same issue I get on my home laptop when building, which is something related to ForceSet)

[benwaffle]

../src/function.cc:59:58: error: too few arguments to function call, expected 4, have 3
    auto res = stringify->CallAsFunction(JSON, 1, args_js);
               ~~~~~~~~~~~~~~~~~~~~~~~~~                 ^

../node_modules/nan/nan_callbacks_12_inl.h:108:64: error: no member named 'Callee' in 'v8::FunctionCallbackInfo<v8::Value>'
  inline v8::Local<v8::Function> Callee() const { return info_.Callee(); }
                                                         ~~~~~ ^

[romgrk]

0d789b9 will solve the top one.

Bottom one is probably related to invalid node or nan headers. Could you try to find which version of node and nan headers are used?

• Nan: cat node_modules/nan/package.json | grep '"version"'
• Node: search in ./build/node-gtk.target.mk for .node-gyp, or list ~/.nody-gyp (if you don't find, link to a paste of the complete build output)

[romgrk]

Could reproduce the issue, opened nodejs/nan#788.

[romgrk]

Basically, it seems that nan doesn't support node 10.x even though it says it does. The reason is that FunctionCallbackInfo.Callee has been deprecated & removed on V8, but nan didn't catch up.

For the moment, it's possible to build and run on node 10.x by commenting the line 108 of node_modules/nan/nan_callbacks_12_inl.h. We'll wait for a reply from nan's maintainer to check for a more permanent solution.

[romgrk]

Waiting for a PR on the upstream nan to be merged, but this should now compile anyway (tested on 10.2.1). Does it work for you, @benwaffle?

[benwaffle]

yep