language_attributes() in header.php about sage

[retlehs]

doing that makes it spit out lang="en-US" rather than lang="en" i believe which is why i didn't originally do it

will look into this further, and also we'll be implementing #24 soon

thanks for the issue

[bjornjohansen]

Well, if "en-US" isn't what you want, you probably should edit the constant WPLANG in your wp-config.php.

Thanks for the good work BTW. Just reading the documentation was a joy :-)

[swalkinshaw]

en-US is actually a valid language code: http://www.w3.org/TR/html401/struct/dirlang.html#h-8.1.1

I'm assuming there wouldn't be much real world difference between "en" and "en-US" since the primary code is still the same.

[philipashlock]

Why is "en-US" converted to "en" when it is a valid language code (as @swalkinshaw said) and is based on what is already properly set by (or defaulted to by) WPLANG?

I also don't understand why dir="rtl" is added if applicable, but dir="ltr" is not

Furthermore, it doesn't look like is_rtl() is used properly since it's only supposed to return a boolean - http://codex.wordpress.org/Function_Reference/is_rtl

[swalkinshaw]

@philipashlock thanks for bringing this up again. See #942 for updates.