GithubHelp home page GithubHelp logo

Comments (12)

sckott avatar sckott commented on June 15, 2024

I agree that any one person will likely stick to one way or the other.

I think we should stick with what you've done for now - we should get others to take a look at the entire package soonish and if there's a strong feeling about changes, we can talk about that then

from taxa.

zachary-foster avatar zachary-foster commented on June 15, 2024

Sounds good

from taxa.

zachary-foster avatar zachary-foster commented on June 15, 2024

Do we still want to have others weigh in on this? I can ask a few coworkers.

from taxa.

sckott avatar sckott commented on June 15, 2024

yeah, that'd be great

from taxa.

zachary-foster avatar zachary-foster commented on June 15, 2024

Hey @knausb and @Tabima, would you mind weighing in on this if you have time? Thanks!

from taxa.

zachary-foster avatar zachary-foster commented on June 15, 2024

Oh yea, and we would of course like to hear from @grunwald as well.

from taxa.

knausb avatar knausb commented on June 15, 2024

I think its great that you have engineered both behaviours! I think that will make the package approachable to those of us who have a more more 'base R' perspective as well as those who want the side effects version.

from taxa.

zachary-foster avatar zachary-foster commented on June 15, 2024

Thanks for the feedback @knausb!

from taxa.

grunwald avatar grunwald commented on June 15, 2024

I agree with all comments and support the dual approach.

from taxa.

zachary-foster avatar zachary-foster commented on June 15, 2024

Think we can close this or do we want more input?

from taxa.

sckott avatar sckott commented on June 15, 2024

i think we can close

from taxa.

zachary-foster avatar zachary-foster commented on June 15, 2024

Cool

from taxa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.