Comments (4)
Oh, that's exactly what I had in mind, defunct with an informative message! Great, I'll open the PR in a bit.
from webchem.
If possible, this should deprecated, not removed. Ideally it would continue to work (by passing args to the appropriate pc_* function) and print a warning with information about how to update code. Then in a later version, it would print an error with information about how to update code.
We should probably eventually develop some kind of deprecation policies since this kind of thing will continue to happen as APIs evolve.
from webchem.
Thanks @Aariq, valid point about deprecating first instead of "defunct"-ing in one step.
I understand that normally we would remove functions over time, but in this case it is not webchem that changed but the webservice, so this might be a different scenario? I haven't looked into your suggestion in detail but probably some of the list elements could be reproduced through pc_sect()
calls and some downstream processing.
On the other hand, I do not have a recorded response to test any new implementation with. Also I'm a little worried about the amount of effort it would require from us to make it work again (another difference from normal function lifecycle), not sure whether this should be our problem?
In general, if APIs stop working then in most cases we won't be able to fix it, so maybe our role is just to make sure webchem is not polluted with functions that no longer work? This one is different because it no longer works, but luckily we already implemented PubChem so we might be able to rewrite the backend to emulate the user experience. Just not sure if we should put effort into something that's already outdated.
from webchem.
We could just defunct it and print an error that blames the API provider and a suggestion for an alternative. I'd be ok with that. Whatever we decide, it might be good to take some notes about it in CONTRIBUTING.md
from webchem.
Related Issues (20)
- Fix pkgdown config for reference HOT 3
- RI Extraction issue HOT 3
- Release webchem 1.2.0
- Common Chemistry CAS API
- Any way to search by Mass? HOT 4
- extract PubChem section's content HOT 2
- improve reliability of `with_cts()` HOT 2
- Use `httptest` for API mocking HOT 7
- error with etox_basic() HOT 1
- nist_ri() fails HOT 5
- Release webchem 1.3.0 HOT 1
- `pan_query()` still broken. Should it be made defunct for v 1.3.0? HOT 5
- is.na > 1 error HOT 5
- Character CID that can't be coerced to numeric in `pc_prop()` results in `NA` output for all CIDs HOT 13
- cir_query doesn't return SMILES string even though it exists in PubChem HOT 2
- Improve input validation HOT 1
- Add vignettes (back?) to pkgdown website HOT 2
- pc_sect and section EPA-IRIS-Informtion HOT 2
- Get_cid pulls many CIDs, some wrong HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webchem.