Comments (3)
I'm going to mark this as backlog.
It's not 100% clear to me what the right behavior is here. What did we do in ROS 1? There also may be some funniness with Windows.
from launch.
So the longer discussion was that it should probably return 130 on ctrl-c, since that is the error code that represents that an interactive application was interrupted.
I don't think anybody would be opposed to launch
having that behavior as well.
Adjacent to that, it would be interesting to know how roslaunch
did it, and if not returning 130
was keeping in line with that precedent or just an oversight.
Additionally, all bets are off with Windows and how it handles interrupts and return codes, so it would be somewhat worthwhile to try to make the behaviors consistent.
from launch.
Sad to report that roslaunch
returns 0 in most cases except for exceptions (which sigint does not generate)
from launch.
Related Issues (20)
- Bug or feature? PushRosNamespace is not forwarded to managed actions HOT 4
- XMLLaunchDescriptionSource: Unknown substitution: find HOT 1
- [FeatureRequest] Is it possible to skip argument checking in include_launch_description
- Launch doesn't stop running nodes when exception thrown HOT 2
- Can't include [launch_testing_ament_cmake] in a launch only package HOT 1
- Bug when setting launch arguments of included descriptions HOT 1
- Requirement:Only start all nodes and then this ros2 launch process exit HOT 2
- `ExecuteProcess` with `shell=True` gets incorrect exit code from the executed process HOT 2
- Add an option to disable creating log files by the launch system HOT 1
- Unexpected YAML parsing with get_attr and List[Entity] type HOT 1
- pytest 8.1 incompatibility: TypeError: import_path() missing 1 required keyword-only argument: 'consider_namespace_packages' HOT 3
- Tests on Windows falsely positive reporting passed due to SIGINT handling HOT 1
- ThisLaunchFileDir throws error in debug mode
- Change ISSUE_TEMPLATE.md HOT 1
- RegisterEventHandler: action_matcher must be an 'ExecuteProcess' instance or a callable HOT 2
- Request for Release in Iron HOT 2
- Feature request: run multiple tests in parallel with `colcon test` HOT 3
- Default port and address of 'foxglove_bridge_launch.xml' not met when launching HOT 1
- Parameterized `launch_pytest` tests don't close node log files HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from launch.