GithubHelp home page GithubHelp logo

Comments (3)

ivanpauno avatar ivanpauno commented on July 28, 2024 1

I think that the graph guard condition should be triggered in all graph changes.
A summary of graph changes:

  • Anything that can change the output of the functions here.
  • subscription and publisher matching count: this and this.

About non-dds rmw implementations, FastRTPS didn't use to have wait sets (now FastDDS have).
They implemented rmw wait sets with the use of cv and listeners, so I think every non-DDS rmw implementation should be able to do that.

We could also have more fine grained guard conditions in the future.

About the difference between events and the graph guard condition, I think that in the future we could have a single event/condition type that can be added to the wait set instead of the wait set being able to wait in different kinds of objects.

from rmw.

hidmic avatar hidmic commented on July 28, 2024

Alright, as per offline discussion, we've agreed that the global guard condition should be able to detect all the aforementioned ROS graph events. #272 is a first step in this direction, updating the API spec.

from rmw.

hidmic avatar hidmic commented on July 28, 2024

Alright, since #272 publisher/subscription matching must trigger the graph guard condition. Implementations must now be adapted.

from rmw.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.