Comments (4)
Image is located at a URL with the form https://raw.githubusercontent.com/OWNER/REPO/COMMIT_SHA/game/current/board.svg
.
There's a problem with that: that URL involves the commit hash for a commit that, with #33, does not yet exist. There's no way of knowing what our next commit hash is going to be. I can't just use the current URL for the current one and log the commit hash URL, because then we'd have caching issues and no one would be able to see the current image.
You know what, I haven't tried it. Let's see what happens.
Because I'm adding to the log each commit, I can't target the current commit to add an absolute URL there, either. But what I can do is go back over the log with each commit and add the hash of the previous commit. Yep. That's a completely foolproof idea.
from rossjrw.
Noting that images currently point to games/current
. When a new game is created, that does not need to be changed. The reference by commit hash should be correct.
from rossjrw.
Confirmed - caching is an issue. I'll have to retain the image hash in the event log.
from rossjrw.
You know, I wouldn't have to both generate and retain a special hash for the board image if I just used the issue number.
from rossjrw.
Related Issues (20)
- ur-move-3@4-0 HOT 1
- ur-move-2@4-0 HOT 1
- ur-move-2@0-0 HOT 1
- ur-move-2@6-0 HOT 1
- ur-move-2@6-0 HOT 1
- ur-move-2@0-0 HOT 1
- ur-move-2@4-0 HOT 1
- ur-move-2@2-0 HOT 1
- ur-move-2@4-0 HOT 1
- ur-move-2@4-0 HOT 1
- ur-move-2@0-0 HOT 1
- ur-move-3@1-0 HOT 1
- ur-move-3@0-0 HOT 1
- ur-move-2@4-0 HOT 1
- ur-move-1@0-0 HOT 1
- ur-move-2@2-0 HOT 1
- ur-move-2@2-0 HOT 1
- ur-move-2@2-0 HOT 1
- ur-move-2@7-0 HOT 1
- ur-move-2@4-0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rossjrw.