Comments (5)
No problem. Just ask me if you need some help (if this is your first pull request, it might appear a bit complex)
from from-python-to-numpy.
Yes, this is the perfect place to report the issue. Thanks a lot and I think you're right that there's a problem. Could you make a PR to fix it?
from from-python-to-numpy.
I will... As soon as I learn how to do it properly :)
Sorry for being such a noob, I'll look into it when I get a quiet 1/2h today.
from from-python-to-numpy.
Thanks Nicolas,
indeed I need some help. When trying to issue a new PR, I should input the reference and the modified branch, which I understand should be your base and my 'proposal', respectively. Is this understanding correct?
If yes, I don't know how to create the proposal for change. I'm trying to work out what has been done for another PR I can see:
So there's a txt file which has been modified in a diagram about the location of a pointer. The txt file is a chapter of your book I surmise... Shall I do the same action? Propose a mod version of your chapter?
If yes, how do I do that?
from from-python-to-numpy.
The easiest way, when the change is small is to browse the file on my repository and to "edit" it (the pen button on upper right). Since you do not have rights to modify the file, GitHub will propose you automatically to make a PR for proposing your change.
The other way is more complex but not that much:
- Fork the repository in you GtiHub account
- Clone your new forked directory on you computer
- cd to to you directoy and create new branch (
git checkout -b "corrections"
for example) - Do some change to the files, add them for the next commit (
git add
) - Do the actual commit (
git commit -m "message"
) - Push your changes (
git push
)
And you're mostly done. If you go on GitHub gain, you'll see your last commit and GitHub will propose you to make a PR.
If it's not clear, just tell me. I remember that I totally messed up my first PR a few years ago and someone helped me a lot)
from from-python-to-numpy.
Related Issues (20)
- Explanation of speed difference between `random_walk` and `random_walk_faster` looks misleading HOT 1
- Explanation of speed difference between `random_walk` and `random_walk_faster` looks misleading HOT 4
- Broken link HOT 2
- Idiomatic English HOT 2
- Error in the find_index functon HOT 1
- anatomy of an array: multidimensional array start and stop from view HOT 5
- Bug in R"eadability vs speed" section HOT 2
- `smoke` example fails on numpy 1.24.2 HOT 3
- Chapter 4.2: Uniform vectorization - NameError: name 'shape' is not defined HOT 6
- 2.1 `random_walk_fastest` is slightly incorrect: does not include starting position `0` HOT 1
- 2.2 Readability VS Speed HOT 1
- mention einsum HOT 4
- 4.2. Uniform vectorization/Python implementation bug HOT 1
- 4.4 Spatial vectorization/numpy implementation incorrect operators HOT 4
- Can you provide an info file for reading this in Emacs? HOT 1
- Jupyter-book version HOT 3
- Question on the content of the book HOT 1
- neighbours array in game of life example (Uniform Vectorization) HOT 3
- PDF version of the book HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from from-python-to-numpy.