GithubHelp home page GithubHelp logo

Comments (7)

rmdort avatar rmdort commented on May 1, 2024

There was no significant changes in v8. What version of typescript are you using ? How are you importing the grid?

from grid.

esakylli avatar esakylli commented on May 1, 2024

I'm using TypeScript 4.2.3, and here's how I import the grid:
import {
autoSizerCanvas,
CellInterface,
Grid,
GridRef,
Cell,
RendererProps,
UseEditableOptions,
useEditable,
useSelection,
} from "@rowsncolumns/grid";

If I compile your code in my dev environment, it works.

from grid.

rmdort avatar rmdort commented on May 1, 2024

I guess some import might be conflicting.. Can you share your tsconfig settings.. If you could reproduce this on codesandbox, will be helpful

from grid.

esakylli avatar esakylli commented on May 1, 2024

I just looked at the generated JS-file for grid. There seems to be a difference in the module loading.

Here's the old snippet:
var __importStar = (this && this.__importStar) || function (mod) {
if (mod && mod.__esModule) return mod;
var result = {};
if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
__setModuleDefault(result, mod);
return result;
};

Here's the new snippet (v8.0.8):
var __importStar = (this && this.__importStar) || function (mod) {
if (mod && mod.__esModule) return mod;
var result = {};
if (mod != null) for (var k in mod) if (Object.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
__setModuleDefault(result, mod);
return result;
};

from grid.

esakylli avatar esakylli commented on May 1, 2024

Maybe you have used a different version of tsc when building/publishing?

from grid.

rmdort avatar rmdort commented on May 1, 2024

I dont have a way to reproduce this. You can share your tsconfig.json or use codesandbox to reproduce this error.

from grid.

esakylli avatar esakylli commented on May 1, 2024

Unfortunately, I didn't manage to reproduce the error in codesandbox.

Here's my tsconfig.json:

{
"extends": "../tsconfig.settings.json",
"compilerOptions": {
"outDir": "lib",
"rootDir": "src",
"lib": ["dom", "es2015", "es2017.object", "esnext.asynciterable", "esnext"]
}
}

tsconfig.settings.json:

{
"compilerOptions": {
"target": "es5",
"module": "commonjs",
"declaration": true,
"declarationMap": true,
"sourceMap": true,
"composite": true,
"esModuleInterop": true,
"downlevelIteration": true,
"jsx": "react",
"newLine": "LF",
"noEmitOnError": false,
"noFallthroughCasesInSwitch": true,
"noImplicitAny": true,
"noImplicitReturns": true,
"noImplicitThis": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"strictNullChecks": true,
"lib": ["esnext"],
"noErrorTruncation": true
}
}

from grid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.