build warnings about rpki-client-portable

[robert-scheck]

I can confirm two warnings for builds on a modern Linux for x86_64, i686, aarch64, armv7hl, ppc64le:

recallocarray.c: In function 'recallocarray':
recallocarray.c:60:28: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'int' [-Wsign-compare]
   60 |   if (d < oldsize / 2 && d < getpagesize()) {
      |                            ^

main.c:482:3: warning: ignoring return value of 'asprintf' declared with attribute 'warn_unused_result' [-Wunused-result]
  482 |   asprintf(&tmp, "%s %s", stats.talnames, file);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

For s390x, I'm seeing however more warnings, but only there.

Only other unrelated, minor thing I didn't see mentioned that was /usr/local/var/cache/rpki-client needs to be setup with the default build and instantiation before rpki-client can be successfully run.

What do you mean by that exactly? There is an install-data-hook as part of make install that should either cover it (or raise a message).

[jtkristoff]

When I first started rpki-client, this was the result:

$ rpki-client -c
rpki-client: /usr/local/var/cache/rpki-client: chdir: No such file or directory
rpki-client: poll: hangup

After mkdir'ing that directory and chown'ing to _rpki-client, things worked fine. update: Same situation for the outputdir.

Oh, and I hate to add random things to this issue, but there is also no mention of the ARIN TAL. I know that situation is less than ideal, but getting it is probably worth a mention.

[cjeker]

The getpagesize() warning is harmless. getpagesize() will always return a positive number. Unsure if we should add a cast to size_t. Not a big fan of such casts.

The asprintf() warning is something that should be fixed. I look into it.

The s390x related warnings are because of a compiler that is not smart enough for its own good. The strdup() calls are unreachable if desrc is NULL. The code could be changed to help such compilers and also us humans.

Unsure about ar(1) related warnings. This is from deep down the autoconf rabbit hole. The makefile tries to be smart and only partially update the archives but it seems some systems have D (deterministic mode) by default and then u does not work and is ignored.

[sebastianbenoit]

The asprintf() warning is something that should be fixed. I look into it.

Claudio fixed this some time ago.

[cjeker]

As mentioned by @sebastianbenoit many things got fixed in -current and 6.8.
If there are more issues please open a new ticket.