Comments (5)
I can confirm two warnings for builds on a modern Linux for x86_64, i686, aarch64, armv7hl, ppc64le:
recallocarray.c: In function 'recallocarray':
recallocarray.c:60:28: warning: comparison of integer expressions of different signedness: 'size_t' {aka 'long unsigned int'} and 'int' [-Wsign-compare]
60 | if (d < oldsize / 2 && d < getpagesize()) {
| ^
main.c:482:3: warning: ignoring return value of 'asprintf' declared with attribute 'warn_unused_result' [-Wunused-result]
482 | asprintf(&tmp, "%s %s", stats.talnames, file);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
For s390x, I'm seeing however more warnings, but only there.
Only other unrelated, minor thing I didn't see mentioned that was
/usr/local/var/cache/rpki-client
needs to be setup with the default build and instantiation before rpki-client can be successfully run.
What do you mean by that exactly? There is an install-data-hook as part of make install
that should either cover it (or raise a message).
from rpki-client-portable.
When I first started rpki-client, this was the result:
$ rpki-client -c
rpki-client: /usr/local/var/cache/rpki-client: chdir: No such file or directory
rpki-client: poll: hangup
After mkdir'ing that directory and chown'ing to _rpki-client, things worked fine. update: Same situation for the outputdir
.
Oh, and I hate to add random things to this issue, but there is also no mention of the ARIN TAL. I know that situation is less than ideal, but getting it is probably worth a mention.
from rpki-client-portable.
The getpagesize() warning is harmless. getpagesize() will always return a positive number. Unsure if we should add a cast to size_t. Not a big fan of such casts.
The asprintf() warning is something that should be fixed. I look into it.
The s390x related warnings are because of a compiler that is not smart enough for its own good. The strdup() calls are unreachable if desrc is NULL. The code could be changed to help such compilers and also us humans.
Unsure about ar(1) related warnings. This is from deep down the autoconf rabbit hole. The makefile tries to be smart and only partially update the archives but it seems some systems have D (deterministic mode) by default and then u does not work and is ignored.
from rpki-client-portable.
The asprintf() warning is something that should be fixed. I look into it.
Claudio fixed this some time ago.
from rpki-client-portable.
As mentioned by @sebastianbenoit many things got fixed in -current and 6.8.
If there are more issues please open a new ticket.
from rpki-client-portable.
Related Issues (20)
- Issuer certificate not found even tough it is in cache `ta` folder HOT 5
- better documentation on metrics
- vis.c warning on debian HOT 1
- Nightly GitHub Action failure: undefined reference to `spl_read'
- Nightly GitHub Action failure HOT 2
- outformats patch misaligned HOT 2
- 7.9 - release HOT 2
- Nightly GitHub Action failure HOT 2
- Upload signing public key of rpki-client to keys.openpgp.org? HOT 2
- Proxy support issues since 8.0 HOT 11
- crash with unhandled entity type 7 HOT 6
- Geofeed validation doesn't seem to work correctly on Ubuntu 22.04.1 LTS - RPKI-client 8.2 HOT 2
- Updated rpki-client interval for crontab?
- Nightly GitHub Action failure HOT 1
- Add ARIN TAL to OpenBSD upstream repository? HOT 2
- Nightly GitHub Action failure HOT 1
- symbol collision between libcompat.a and libtls HOT 2
- Apparent lack of HOST_NAME_MAX on macOS? HOT 2
- GitHub Action failure: undefined reference to `inflate' HOT 1
- Nightly GitHub Action failure: implicit declaration of function 'arc4random_uniform' HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rpki-client-portable.