[BUG] bool type error about drf-access-policy

[rsinger86]

Thanks 🙂. I'll plan to do the 1.0 update later today, it's pretty minor, the main thing is communicating the breaking change in the docs.

…

On Mon, Jul 5, 2021, 4:03 PM Michael Honaker ***@***.***> wrote: @rsinger86 <https://github.com/rsinger86> Thank you for your response and for this project! It has really helped ease the development of my product. How can I go about avoiding this issue (Im planning on opening up my project to beta and this is kinda the last blocker)? I've seen this happen with both simple method conditions as well as a basic complex expression e.g. (is_adminoffice or is_sysadmin) so I'm not really sure how to stop/avoid it. I can also downgrade to 0.8.6 if this error does not occur there. Thank you again for your help. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#66 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB32I5THDBULOZAYDYXCCJTTWIM2BANCNFSM47AQ7MZQ> .

[HonakerM]

@rsinger86 Any help would be greatly appreciated. I thought that the issue could be happening because of a user error but here is my current config and the error still appears:

class GenericObjectPermission(AccessPolicy):
    # ? Used for actual operations
    statements =  [
        {
            "action":["*"],
            "principal":"authenticated",
            "effect":"allow",
            "condition":"is_adminoffice"
        },
        {
            "action":["*"],
            "principal":"authenticated",
            "effect":"allow",
            "condition":"is_sysadmin"
        },

    def is_sysadmin(self, request, view, action) -> bool:
        return True

    def is_adminoffice(self, request, view, action) -> bool:
        return True

The request normally works but sometimes it will fail. This only happens in browser (I have been unable to reproduce it with curl)

[rsinger86]

I'm leaning toward a 1.0 release with a breaking change that delineates the following:

• method conditions that contain complex boolean expressions and are evaluated with pyparsing
• simple method conditions that reference a single method

I made a mistake in not doing this from the start (see #55). I'm thinking the best way to handle would be to have a separate expression_condition key. With this update, your statements would avoid pyparsing.

[HonakerM]

@rsinger86 Thank you for your response and for this project! It has really helped ease the development of my product.

How can I go about avoiding this issue (Im planning on opening up my project to beta and this is kinda the last blocker)? I've seen this happen with both simple method conditions as well as a basic complex expression e.g. (is_adminoffice or is_sysadmin) so I'm not really sure how to stop/avoid it. I can also downgrade to 0.8.6 if this error does not occur there.

Thank you again for your help.

[rsinger86]

@HonakerM the 1.0 release should make this work for you

[HonakerM]

@rsinger86 just checked and it works perfectly!! Will let you know if I encounter the error again. Thank you again for all your work.