GithubHelp home page GithubHelp logo

Comments (6)

rstrouse avatar rstrouse commented on August 23, 2024

The real issue here seems to be that sending a target when the target is already the position is the problem. It should not command the movement in this case and I see where the moveToTiltTarget method is not properly performing this check when it is integrated tilt. For tilt motors the code is correct but what it is doing now is initiating a my when it should be checking to make sure it is not idle before seeking.

from espsomfy-rts.

rstrouse avatar rstrouse commented on August 23, 2024

Are your blinds tilt only?

from espsomfy-rts.

joneshf avatar joneshf commented on August 23, 2024

That's correct, they are tilt-only blinds.

from espsomfy-rts.

rstrouse avatar rstrouse commented on August 23, 2024

v2.3.1 is in pre-release and it should resolve the issue of re-entrant targets on the endpoint when there is not a separate tilt and lift motor. Essentially, it needed to check if the target = the current position then do nothing.

from espsomfy-rts.

rstrouse avatar rstrouse commented on August 23, 2024

v2.3.1 has been released and the tiltCommand now verifies the current position before acting.

from espsomfy-rts.

joneshf avatar joneshf commented on August 23, 2024

Had a chance to update to 2.3.1 and tried this out. I can confirm that this now works as expected for the PUT /tiltCommand endpoint, and more importantly for the set_tilt_position service.

Thanks for fixing this!

from espsomfy-rts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.