GithubHelp home page GithubHelp logo

Comments (5)

crudh avatar crudh commented on July 24, 2024

Seems like a problem in the addToResult function in the merge function:

if (mergerResult) {

So if the result from the merger is not truthy it will go to the else and use the value from o. It should do an explicit check for undefined instead. But I guess a fix for that would require a new major version since it can break stuff.

from seamless-immutable.

nickydonna avatar nickydonna commented on July 24, 2024

@crudh Ok, but it seem like a major issue, since anyone using null values can have issues like this and its rather hard to track

from seamless-immutable.

crudh avatar crudh commented on July 24, 2024

@donnanicolas yeah, I agree. PR #248 should fix it.

from seamless-immutable.

nickydonna avatar nickydonna commented on July 24, 2024

@crudh Thanks!! will update as soon as the PR is merged!! (I "reviewed" it and it seems great, but I don't know much about the code)

from seamless-immutable.

crudh avatar crudh commented on July 24, 2024

This is fixed now, a release will be done soon.

from seamless-immutable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.