Cannot build RTK with Visual Studio when RTK_USE_CUDA is enabled about rtk

[SimonRit]

Thanks for the report. I could not reproduce the problem
https://my.cdash.org/buildSummary.php?buildid=1457727
https://my.cdash.org/buildSummary.php?buildid=1457591
The failing tests with shared libs probably come from the FFTW bug that I corrected after ITK 4.13. Is it really master or have you applied GH-187?

[dzenanz]

That was with PR187 applied. But since I had my ITK built with all legacy OFF, I needed that or else I run into "itkGetObjectMacro is not defined" error.

[SimonRit]

Commits 095323c and 59647bc should fix it, it would be great if you can confirm.

[dzenanz]

I am on vacation, so it will take a while :)

…

On Tue, Jun 12, 2018, 14:27 Simon Rit ***@***.***> wrote: Commits 095323c <SimonRit@095323c> and 59647bc <SimonRit@59647bc> should fix it, it would be great if you can confirm. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/SimonRit/RTK/issues/188#issuecomment-396571107>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABtYedbpxqODJw6LAhePnnwkBDXPQ7ATks5t77OogaJpZM4Uc_n8> .

[SimonRit]

I'm closing it but don't hesitate to reopen if we missed something. Thanks again for the report!

[dzenanz]

With current master, the build still fails:

1>------ Build started: Project: RTK, Configuration: Release x64 ------
2>------ Skipped Build: Project: ITKHeaderTests, Configuration: Release x64 ------
2>Project not selected to build for this solution configuration 
1>  rtkCudaParkerShortScanImageFilter.cxx
1>C:\Misc\RTK\src\rtkCudaParkerShortScanImageFilter.cxx(78): error C2662: 'const std::map<double,unsigned int,std::less<_Kty>,std::allocator<std::pair<const _Kty,_Ty>>> rtk::ThreeDCircularProjectionGeometry::GetUniqueSortedAngles(const std::vector<double,std::allocator<double>> &)': cannot convert 'this' pointer from 'const rtk::ParkerShortScanImageFilter<itk::CudaImage<float,3>,TInputImage>::GeometryType' to 'rtk::ThreeDCircularProjectionGeometry &'
1>          with
1>          [
1>              _Kty=double,
1>              _Ty=unsigned int
1>          ]
1>          and
1>          [
1>              TInputImage=itk::CudaImage<float,3>
1>          ]
1>  C:\Misc\RTK\src\rtkCudaParkerShortScanImageFilter.cxx(78): note: Conversion loses qualifiers
3>------ Build started: Project: rtkextractshroudsignal, Configuration: Release x64 ------
4>------ Build started: Project: rtkimagxgeometry, Configuration: Release x64 ------
3>  rtkextractshroudsignal.cxx
4>  rtkimagxgeometry.cxx
3>c:\misc\rtk\include\rtkReg1DExtractShroudSignalImageFilter.hxx(169): error C2440: 'initializing': cannot convert from 'const itk::Image<OutputPixelType,1> *' to 'itk::SmartPointer<itk::Image<OutputPixelType,1>>'
3>  c:\misc\rtk\include\rtkReg1DExtractShroudSignalImageFilter.hxx(169): note: No constructor could take the source type, or constructor overload resolution was ambiguous
3>  c:\misc\rtk\include\rtkReg1DExtractShroudSignalImageFilter.hxx(142): note: while compiling class template member function 'void rtk::Reg1DExtractShroudSignalImageFilter<InputPixelType,OutputPixelType>::GenerateData(void)'
3>  C:\Misc\RTK\applications\rtkextractshroudsignal\rtkextractshroudsignal.cxx(77): note: see reference to class template instantiation 'rtk::Reg1DExtractShroudSignalImageFilter<InputPixelType,OutputPixelType>' being compiled
3>c:\misc\rtk\include\rtkReg1DExtractShroudSignalImageFilter.hxx(190): error C2679: binary '=': no operator found which takes a right-hand operand of type 'const itk::Image<OutputPixelType,1> *' (or there is no acceptable conversion)
3>  c:\libs\insighttoolkit-4.13.0\modules\core\common\include\itkSmartPointer.h(121): note: could be 'itk::SmartPointer<itk::Image<OutputPixelType,1>> &itk::SmartPointer<itk::Image<OutputPixelType,1>>::operator =(itk::Image<OutputPixelType,1> *)'
3>  c:\libs\insighttoolkit-4.13.0\modules\core\common\include\itkSmartPointer.h(117): note: or       'itk::SmartPointer<itk::Image<OutputPixelType,1>> &itk::SmartPointer<itk::Image<OutputPixelType,1>>::operator =(const itk::SmartPointer<itk::Image<OutputPixelType,1>> &)'
3>  c:\misc\rtk\include\rtkReg1DExtractShroudSignalImageFilter.hxx(190): note: while trying to match the argument list '(itk::SmartPointer<itk::Image<OutputPixelType,1>>, const itk::Image<OutputPixelType,1> *)'
4>c:\misc\rtk\include\rtkImagXGeometryReader.hxx(58): error C2440: 'initializing': cannot convert from 'const itk::DOMNodeXMLReader::OutputType *' to 'itk::SmartPointer<itk::DOMNode::Self>'
4>  c:\misc\rtk\include\rtkImagXGeometryReader.hxx(58): note: No constructor could take the source type, or constructor overload resolution was ambiguous
4>  c:\misc\rtk\include\rtkImagXGeometryReader.hxx(48): note: while compiling class template member function 'rtk::ImagXGeometryReader<OutputImageType>::FlexmapType rtk::ImagXGeometryReader<OutputImageType>::GetGeometryForAI2p1(void)'
4>  c:\misc\rtk\include\rtkImagXGeometryReader.hxx(499): note: see reference to function template instantiation 'rtk::ImagXGeometryReader<OutputImageType>::FlexmapType rtk::ImagXGeometryReader<OutputImageType>::GetGeometryForAI2p1(void)' being compiled
4>  c:\misc\rtk\include\rtkImagXGeometryReader.hxx(479): note: while compiling class template member function 'void rtk::ImagXGeometryReader<OutputImageType>::GenerateData(void)'
4>  C:\Misc\RTK\applications\rtkimagxgeometry\rtkimagxgeometry.cxx(34): note: see reference to class template instantiation 'rtk::ImagXGeometryReader<OutputImageType>' being compiled
4>c:\misc\rtk\include\rtkImagXGeometryReader.hxx(341): error C2440: 'initializing': cannot convert from 'const itk::DOMNodeXMLReader::OutputType *' to 'itk::SmartPointer<itk::DOMNode::Self>'
4>  c:\misc\rtk\include\rtkImagXGeometryReader.hxx(341): note: No constructor could take the source type, or constructor overload resolution was ambiguous
4>  c:\misc\rtk\include\rtkImagXGeometryReader.hxx(328): note: while compiling class template member function 'rtk::ImagXGeometryReader<OutputImageType>::CalibrationModelType rtk::ImagXGeometryReader<OutputImageType>::GetGeometryForAI1p5FromXMLFiles(void)'
4>  c:\misc\rtk\include\rtkImagXGeometryReader.hxx(514): note: see reference to function template instantiation 'rtk::ImagXGeometryReader<OutputImageType>::CalibrationModelType rtk::ImagXGeometryReader<OutputImageType>::GetGeometryForAI1p5FromXMLFiles(void)' being compiled
4>c:\misc\rtk\include\rtkImagXGeometryReader.hxx(414): error C2679: binary '=': no operator found which takes a right-hand operand of type 'const itk::DOMNodeXMLReader::OutputType *' (or there is no acceptable conversion)
4>  c:\libs\insighttoolkit-4.13.0\modules\core\common\include\itkSmartPointer.h(121): note: could be 'itk::SmartPointer<itk::DOMNode::Self> &itk::SmartPointer<itk::DOMNode::Self>::operator =(itk::DOMNode *)'
4>  c:\libs\insighttoolkit-4.13.0\modules\core\common\include\itkSmartPointer.h(117): note: or       'itk::SmartPointer<itk::DOMNode::Self> &itk::SmartPointer<itk::DOMNode::Self>::operator =(const itk::SmartPointer<itk::DOMNode::Self> &)'
4>  c:\misc\rtk\include\rtkImagXGeometryReader.hxx(414): note: while trying to match the argument list '(itk::DOMNode::Pointer, const itk::DOMNodeXMLReader::OutputType *)'
5>------ Skipped Build: Project: INSTALL, Configuration: Release x64 ------
5>Project not selected to build for this solution configuration 
========== Build: 0 succeeded, 3 failed, 66 up-to-date, 2 skipped ==========

[SimonRit]

Just pushed a fix, I hope it works now...

[dzenanz]

With master, the errors are still there:

1>------ Skipped Build: Project: ITKHeaderTests, Configuration: Release x64 ------
1>Project not selected to build for this solution configuration 
2>------ Build started: Project: rtkextractshroudsignal, Configuration: Release x64 ------
3>------ Build started: Project: rtkimagxgeometry, Configuration: Release x64 ------
3>  rtkimagxgeometry.cxx
2>  rtkextractshroudsignal.cxx
2>c:\misc\rtk\include\rtkReg1DExtractShroudSignalImageFilter.hxx(169): error C2440: 'initializing': cannot convert from 'const itk::Image<OutputPixelType,1> *' to 'itk::SmartPointer<itk::Image<OutputPixelType,1>>'
2>  c:\misc\rtk\include\rtkReg1DExtractShroudSignalImageFilter.hxx(169): note: No constructor could take the source type, or constructor overload resolution was ambiguous
2>  c:\misc\rtk\include\rtkReg1DExtractShroudSignalImageFilter.hxx(142): note: while compiling class template member function 'void rtk::Reg1DExtractShroudSignalImageFilter<InputPixelType,OutputPixelType>::GenerateData(void)'
2>  C:\Misc\RTK\applications\rtkextractshroudsignal\rtkextractshroudsignal.cxx(77): note: see reference to class template instantiation 'rtk::Reg1DExtractShroudSignalImageFilter<InputPixelType,OutputPixelType>' being compiled
2>c:\misc\rtk\include\rtkReg1DExtractShroudSignalImageFilter.hxx(190): error C2679: binary '=': no operator found which takes a right-hand operand of type 'const itk::Image<OutputPixelType,1> *' (or there is no acceptable conversion)
2>  c:\libs\insighttoolkit-4.13.0\modules\core\common\include\itkSmartPointer.h(121): note: could be 'itk::SmartPointer<itk::Image<OutputPixelType,1>> &itk::SmartPointer<itk::Image<OutputPixelType,1>>::operator =(itk::Image<OutputPixelType,1> *)'
2>  c:\libs\insighttoolkit-4.13.0\modules\core\common\include\itkSmartPointer.h(117): note: or       'itk::SmartPointer<itk::Image<OutputPixelType,1>> &itk::SmartPointer<itk::Image<OutputPixelType,1>>::operator =(const itk::SmartPointer<itk::Image<OutputPixelType,1>> &)'
2>  c:\misc\rtk\include\rtkReg1DExtractShroudSignalImageFilter.hxx(190): note: while trying to match the argument list '(itk::SmartPointer<itk::Image<OutputPixelType,1>>, const itk::Image<OutputPixelType,1> *)'
3>c:\misc\rtk\include\rtkImagXGeometryReader.hxx(58): error C2440: 'initializing': cannot convert from 'const itk::DOMNodeXMLReader::OutputType *' to 'itk::SmartPointer<itk::DOMNode::Self>'
3>  c:\misc\rtk\include\rtkImagXGeometryReader.hxx(58): note: No constructor could take the source type, or constructor overload resolution was ambiguous
3>  c:\misc\rtk\include\rtkImagXGeometryReader.hxx(48): note: while compiling class template member function 'rtk::ImagXGeometryReader<OutputImageType>::FlexmapType rtk::ImagXGeometryReader<OutputImageType>::GetGeometryForAI2p1(void)'
3>  c:\misc\rtk\include\rtkImagXGeometryReader.hxx(499): note: see reference to function template instantiation 'rtk::ImagXGeometryReader<OutputImageType>::FlexmapType rtk::ImagXGeometryReader<OutputImageType>::GetGeometryForAI2p1(void)' being compiled
3>  c:\misc\rtk\include\rtkImagXGeometryReader.hxx(479): note: while compiling class template member function 'void rtk::ImagXGeometryReader<OutputImageType>::GenerateData(void)'
3>  C:\Misc\RTK\applications\rtkimagxgeometry\rtkimagxgeometry.cxx(34): note: see reference to class template instantiation 'rtk::ImagXGeometryReader<OutputImageType>' being compiled
3>c:\misc\rtk\include\rtkImagXGeometryReader.hxx(341): error C2440: 'initializing': cannot convert from 'const itk::DOMNodeXMLReader::OutputType *' to 'itk::SmartPointer<itk::DOMNode::Self>'
3>  c:\misc\rtk\include\rtkImagXGeometryReader.hxx(341): note: No constructor could take the source type, or constructor overload resolution was ambiguous
3>  c:\misc\rtk\include\rtkImagXGeometryReader.hxx(328): note: while compiling class template member function 'rtk::ImagXGeometryReader<OutputImageType>::CalibrationModelType rtk::ImagXGeometryReader<OutputImageType>::GetGeometryForAI1p5FromXMLFiles(void)'
3>  c:\misc\rtk\include\rtkImagXGeometryReader.hxx(514): note: see reference to function template instantiation 'rtk::ImagXGeometryReader<OutputImageType>::CalibrationModelType rtk::ImagXGeometryReader<OutputImageType>::GetGeometryForAI1p5FromXMLFiles(void)' being compiled
3>c:\misc\rtk\include\rtkImagXGeometryReader.hxx(414): error C2679: binary '=': no operator found which takes a right-hand operand of type 'const itk::DOMNodeXMLReader::OutputType *' (or there is no acceptable conversion)
3>  c:\libs\insighttoolkit-4.13.0\modules\core\common\include\itkSmartPointer.h(121): note: could be 'itk::SmartPointer<itk::DOMNode::Self> &itk::SmartPointer<itk::DOMNode::Self>::operator =(itk::DOMNode *)'
3>  c:\libs\insighttoolkit-4.13.0\modules\core\common\include\itkSmartPointer.h(117): note: or       'itk::SmartPointer<itk::DOMNode::Self> &itk::SmartPointer<itk::DOMNode::Self>::operator =(const itk::SmartPointer<itk::DOMNode::Self> &)'
3>  c:\misc\rtk\include\rtkImagXGeometryReader.hxx(414): note: while trying to match the argument list '(itk::DOMNode::Pointer, const itk::DOMNodeXMLReader::OutputType *)'
4>------ Skipped Build: Project: INSTALL, Configuration: Release x64 ------
4>Project not selected to build for this solution configuration 
========== Build: 0 succeeded, 2 failed, 67 up-to-date, 2 skipped ==========

[SimonRit]

I believe I had this time the right configuration to reproduce the bug and fix it
Again, great if you can check before closing.

[dzenanz]

Now it builds and the tests pass.

[SimonRit]

Great, thanks.