Item typing not exported in TS declaration file about pofile

[rubenv]

I'm no expert on TypeScript typings, so I can't really say for sure what the fix is.

@septs Can you have a look at this?

[septs]

@mrjpierce first, this package not is esmodule
The as designed,

pofile/lib/po.js

Line 402 in 8bd7810

module.exports = PO;

@rubenv the issue require use esmodule written this package
WARNING: This needs to break the API backwards compatibility

see https://www.typescriptlang.org/docs/handbook/modules.html#export--and-import--require

[septs]

About get PO.Item instance type, please use the workaround code

type Item = InstanceType<typeof PO["Item"]>

See https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-8.html#conditional-types

[mrjpierce]

@septs

type Item = typeof PO["Item"]["prototype"];

This seems to work for now 👍. Xièxiè

[septs]

@rubenv The issue closable

[rubenv]

@septs thanks!

[septs]

@rubenv I want to rewrite this codebase using TypeScript.

[rubenv]

@septs Could you elaborate a bit on why and how you'd want to do this?

Keep in mind that this is a project I consider "finished": no big new functionality is needed (it does what it needs to do) and we can't break API / backwards compatibilty.

Rewrites are always risky. I'm all for strongly typing things, but it can only be done incrementally and in an extremely careful way: no user should ever see their code break.