Do not require_relative in gemspec about fiddle

[kou]

How about this?

diff --git a/ext/fiddle/fiddle.gemspec b/ext/fiddle/fiddle.gemspec
index befa7aeff5..a3dc425245 100644
--- a/ext/fiddle/fiddle.gemspec
+++ b/ext/fiddle/fiddle.gemspec
@@ -1,18 +1,12 @@
 # frozen_string_literal: true
 
-source_version = ["", "ext/fiddle/"].find do |dir|
-  begin
-    break File.open(File.join(__dir__, "#{dir}lib/fiddle/version.rb")) {|f|
-      f.gets("\n  VERSION = ")
-      f.gets[/\s*"(.+)"/, 1]
-    }
-  rescue Errno::ENOENT
-  end
+unless defined?(Fiddle::VERSION)
+  require_relative "lib/fiddle/version"
 end
 
 Gem::Specification.new do |spec|
   spec.name          = "fiddle"
-  spec.version       = source_version
+  spec.version       = Fiddle::VERSION
   spec.authors       = ["Aaron Patterson", "SHIBATA Hiroshi"]
   spec.email         = ["[email protected]", "[email protected]"]
 

[kou]

I confirmed that this suppresses the warning reported by make test-all TESTS="../ruby/test/ruby/test_gc_compact.rb ../ruby/test/ruby/test_default_gems.rb". (../ruby is the source directory.)

[mame]

Looks good!

[mame]

Ah. You should notice that it may use a wrong version if require "fiddle" is done before loading gemspec. I guess that manual extraction of the version is dirty but more robust. I leave it up to you.

[kou]

I'm not sure that it's caused in real world...

How about this?

diff --git a/ext/fiddle/fiddle.gemspec b/ext/fiddle/fiddle.gemspec
index befa7aeff5..cd9960f3ea 100644
--- a/ext/fiddle/fiddle.gemspec
+++ b/ext/fiddle/fiddle.gemspec
@@ -1,18 +1,13 @@
 # frozen_string_literal: true
 
-source_version = ["", "ext/fiddle/"].find do |dir|
-  begin
-    break File.open(File.join(__dir__, "#{dir}lib/fiddle/version.rb")) {|f|
-      f.gets("\n  VERSION = ")
-      f.gets[/\s*"(.+)"/, 1]
-    }
-  rescue Errno::ENOENT
-  end
+if defined?(Fiddle::VERSION)
+  Fiddle.__send__(:remove_const, :VERSION)
 end
+require_relative "lib/fiddle/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "fiddle"
-  spec.version       = source_version
+  spec.version       = Fiddle::VERSION
   spec.authors       = ["Aaron Patterson", "SHIBATA Hiroshi"]
   spec.email         = ["[email protected]", "[email protected]"]
 

[kou]

Or:

diff --git a/ext/fiddle/fiddle.gemspec b/ext/fiddle/fiddle.gemspec
index befa7aeff5..a6c8c9be00 100644
--- a/ext/fiddle/fiddle.gemspec
+++ b/ext/fiddle/fiddle.gemspec
@@ -1,18 +1,13 @@
 # frozen_string_literal: true
 
-source_version = ["", "ext/fiddle/"].find do |dir|
-  begin
-    break File.open(File.join(__dir__, "#{dir}lib/fiddle/version.rb")) {|f|
-      f.gets("\n  VERSION = ")
-      f.gets[/\s*"(.+)"/, 1]
-    }
-  rescue Errno::ENOENT
-  end
+version_module = Module.new do
+  version_rb = File.join(__dir__, "lib/fiddle/version.rb")
+  module_eval(File.read(version_rb), version_rb)
 end
 
 Gem::Specification.new do |spec|
   spec.name          = "fiddle"
-  spec.version       = source_version
+  spec.version       = version_module::Fiddle::VERSION
   spec.authors       = ["Aaron Patterson", "SHIBATA Hiroshi"]
   spec.email         = ["[email protected]", "[email protected]"]
 

[mame]

I'm okay for any solution including your first one! I just let you be aware of the potential risk.

[kou]

OK. I'll use the last one.