Comments (6)
I don't need all features, but you can go ahead and make your fork
from ferrum.
Hi Petteri, unsubscription sounds good! Though activesupport is a huge dependency, it's better implement it ourselves
from ferrum.
It doesn't really add much memory footprint if we only use the notifications
irb(main):001:0> require 'get_process_mem'
=> true
irb(main):002:0> GetProcessMem.new
=> #<GetProcessMem:0x00000190 @mb=25.609375 @gb=0.0250091552734375 @kb=26224.0 @bytes=26853376>
irb(main):003:0> require 'active_support/notifications'
=> true
irb(main):004:0> ActiveSupport::Notifications.subscribe('foo.example') do |*args| p 'here' end
=> #<ActiveSupport::Notifications::Fanout::Subscribers::Timed:0x00007f824f062768 @pattern="foo.example", @delegate=#<Proc:0x00007f824f0627e0 (irb):4>, @can_publish=false>
irb(main):005:0> ActiveSupport::Notifications.instrument('foo.example') do true end
"here"
=> true
irb(main):009:0> GetProcessMem.new
=> #<GetProcessMem:0x000001e0 @mb=27.3984375 @gb=0.02675628662109375 @kb=28056.0 @bytes=28729344>
``
from ferrum.
Given that you need chrome running to use ferrum, I don't think a bit of memory for active support is that relevant. Of course, up to you.
from ferrum.
I still think that AS is a huge dependency and prefer to keep the stack short, especially when a feature can be implemented relatively easy
from ferrum.
Would you then also prefer to reimplement all the other features that AS would provide?
from ferrum.
Related Issues (20)
- Send Emulation commands to Page HOT 1
- Ferrum::BinaryNotFoundError when using docker for chrome HOT 1
- Can I allow Page.go_to take additional wait parameter?
- Cannot call `exit` from within `.on()` blocks HOT 2
- Exceptions within `.on()` blocks are mysteriously ignored HOT 1
- Browser start fails with JRuby on Windows
- Chrome error: "Unable to create temporary file" on Windows with JRuby HOT 1
- Errno::ECONNREFUSED on browser initialization HOT 3
- Headless new gives Ferrum::NoSuchPageError on screenshot HOT 2
- consider using === in network blacklist matching
- Doesn't work on ruby 3.2 HOT 1
- Saving via browser.mhtml and via cmd+S differs a lot on Youtube HOT 3
- Network.loadingFailed error preventing file from downloading HOT 13
- Conditionally Render Page header and footer template HOT 2
- browser.quit doesn't close session HOT 6
- Include type and stackTrace in logging for console API
- `wait_for_network_idle` failing due to pending requests on previous page HOT 1
- Remove `disable-gpu`default flag for Apple Silicon HOT 3
- authenticate current_user in ferrum browser
- Hang/Timeout in dialog HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ferrum.