GithubHelp home page GithubHelp logo

Comments (6)

route avatar route commented on May 22, 2024 1

I don't need all features, but you can go ahead and make your fork

from ferrum.

route avatar route commented on May 22, 2024

Hi Petteri, unsubscription sounds good! Though activesupport is a huge dependency, it's better implement it ourselves

from ferrum.

betelgeuse avatar betelgeuse commented on May 22, 2024

It doesn't really add much memory footprint if we only use the notifications

irb(main):001:0> require 'get_process_mem'
=> true
irb(main):002:0> GetProcessMem.new
=> #<GetProcessMem:0x00000190 @mb=25.609375 @gb=0.0250091552734375 @kb=26224.0 @bytes=26853376>
irb(main):003:0> require 'active_support/notifications'
=> true
irb(main):004:0> ActiveSupport::Notifications.subscribe('foo.example') do |*args| p 'here' end
=> #<ActiveSupport::Notifications::Fanout::Subscribers::Timed:0x00007f824f062768 @pattern="foo.example", @delegate=#<Proc:0x00007f824f0627e0 (irb):4>, @can_publish=false>
irb(main):005:0> ActiveSupport::Notifications.instrument('foo.example') do true end
"here"
=> true
irb(main):009:0>  GetProcessMem.new
=> #<GetProcessMem:0x000001e0 @mb=27.3984375 @gb=0.02675628662109375 @kb=28056.0 @bytes=28729344>
``

from ferrum.

betelgeuse avatar betelgeuse commented on May 22, 2024

Given that you need chrome running to use ferrum, I don't think a bit of memory for active support is that relevant. Of course, up to you.

from ferrum.

route avatar route commented on May 22, 2024

I still think that AS is a huge dependency and prefer to keep the stack short, especially when a feature can be implemented relatively easy

from ferrum.

betelgeuse avatar betelgeuse commented on May 22, 2024

Would you then also prefer to reimplement all the other features that AS would provide?

from ferrum.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.