Comments (19)
Summary of slack conversation with @lmerriam to clarify reqs
- as soon as the user "turns on" a treatment, it automatically gets its last dose, if it has one
- it would look at the last day the user logged prior to the day they are checking in and use that dose
- this can be done whatever the checkin day is, so no reason to differentiate behavior between today's checkin and past days
from flaredown.
👍
from flaredown.
@algodave this isn't quite working for me, I still get "no dose" on all my treatments when I add them
from flaredown.
@lmerriam can you provide an example treatment you added which was not populated? Consider that currently you have to wait one second before "turning-on" the treatment just added in order to see the auto-set dose (sorry I should have mentioned that)
I'll fix this together with #3 which will provide the app with better awareness on when to trigger checkin save.
from flaredown.
Prednisone, Stelara, Folic Acid, Methotrexate on my [email protected] account
Just tried again waiting 10 seconds, I still see the issue unfortunately
from flaredown.
@lmerriam I should have found what the issue was. I was discarding null
doses but not blank ones. Please try again when you have a chance and let me know. Also note: on a new checkin default doses are immediately available; when you add a new treatment instead, you have to wait one second.
from flaredown.
Looks good now 👍
from flaredown.
@algodave still seeing issues: https://www.dropbox.com/s/zjz5t0f651auuas/autoTreatmentDose.mov?dl=0
from flaredown.
@lmerriam just watched the video. The checkin you clicked on already existed before I released the feature, that means the object was initialized without most-recent doses. I realized that because the summary screen opened up rather than the first checkin screen (the "You haven't checked-in yet").
So to recap: the feature works on new checkins you create from now on, and on not-yet initialized past checkins (i.e. the ones for days which you've never clicked on, if any)
from flaredown.
@lmerriam oh by the way, if you want to test on some past day, I can manually remove your existing checkins; just give me the dates in case you want to do that
from flaredown.
Gotcha! Makes sense. If you wanna clear the past 5 days of my check-ins that would be awesome
from flaredown.
@lmerriam Done!
from flaredown.
@algodave getting the same thing i got before, it seems to be targeting the wrong dose. right now i added a "5mg" dose of prednisone in the days you recently cleared for me, then the next day I turned on prednisone and the auto-dose was "3mg". I have used 3mg before, but not the prior day. Any way I can help diagnose?
from flaredown.
video, in case I'm doing something weird again: https://www.dropbox.com/s/0wzv58dlcdj0p4c/autoTreatmentDose2.mov?dl=0
from flaredown.
No, this time you're not doing anything weird :)
Let me better investigate tomorrow, I'm reopening.
from flaredown.
Random UX thought: if the last dose was "no dose" the auto dose should be "no dose"
from flaredown.
Oh this is important, thanks for posting! At the moment it's ignoring both null
and blank
values while retrieving the most recent. I'll change that.
from flaredown.
@lmerriam You can now test again; let me know which days should I delete checkin for you, if needed.
from flaredown.
Works for me! Closing 👍
from flaredown.
Related Issues (20)
- User request: see a chart for longer periods of time? One month? One year? HOT 1
- User issue: vanishing treatments between checkins HOT 1
- Feature request: update checkin date HOT 1
- Accept the terms sign up checkbox misplaced HOT 2
- Android app won't run on Android 12 (or above?)
- Emotion icons except first missing from symptom checkin (Web)
- Setup staging HOT 3
- upgrade ruby to latest HOT 1
- [native] Wire login page to backend
- [native] Create account from sign up page
- [native] Add captcha to sign up page
- [native] Terms of service and Privacy policy page HOT 1
- [native] Update `react-native-paper` theme to match designs
- Blank login page on first load
- add brakeman security scanner
- Rspec workflow is broken
- Upgrade to Rails 7
- upgrading either rack or puma broke prod cors so I reverted, make the upgrade not do that
- upgrade ruby from 3.1.3 to 3.2.3 HOT 2
- fix and add readme CI badges
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flaredown.