GithubHelp home page GithubHelp logo

references removed about rubyfu HOT 13 CLOSED

noraj avatar noraj commented on June 13, 2024
references removed

from rubyfu.

Comments (13)

KINGSABRI avatar KINGSABRI commented on June 13, 2024 1

It was two sides mistakes. Deleting a huge number of files was hard to review with the limited time I have.

I believe @noraj is working on it already, he's got sharp eyes

from rubyfu.

noraj avatar noraj commented on June 13, 2024

PS only the first 3000 files are displayed on the PR on github of the 4,570 files changed. as node_mobules is alphabetically before references.md we don't see it on the list, you have to check on the CLI.

from rubyfu.

KINGSABRI avatar KINGSABRI commented on June 13, 2024

Omg, @SidWorks there are some issues in your PR. You have deleted markdown files

from rubyfu.

KINGSABRI avatar KINGSABRI commented on June 13, 2024

@noraj thanks man for noticing this issue, we can upload it again. I've created a backup branch before accepting #48 PR. I was really skeptical about it

from rubyfu.

noraj avatar noraj commented on June 13, 2024

@noraj thanks man for noticing this issue

I'm like the watch tower of this project 😂

from rubyfu.

KINGSABRI avatar KINGSABRI commented on June 13, 2024

Yes you are :D . Really nice catch!

from rubyfu.

noraj avatar noraj commented on June 13, 2024

I've created a backup branch before accepting #48 PR. I was really skeptical about it

no need for a backup branch, a git commit can easily be reverted

from rubyfu.

noraj avatar noraj commented on June 13, 2024

by the way this page was remvoed too https://rubyfu.net/required-gems, I'm fixing it all

from rubyfu.

noraj avatar noraj commented on June 13, 2024

@KINGSABRI maybe you could add me to the project and set me as default reviewer (even if I don't have the permission to merge PRs)

from rubyfu.

noraj avatar noraj commented on June 13, 2024

@KINGSABRI Why did you reverted the revert that I made to fix the removed markdown files (babc7ea)? Because you re-removed them 😂

from rubyfu.

KINGSABRI avatar KINGSABRI commented on June 13, 2024

It was a bad move by a sleepy guy

from rubyfu.

noraj avatar noraj commented on June 13, 2024

It was a bad move by a sleepy guy

so should I re-re-revert it or you're doing it?

from rubyfu.

SidWorks avatar SidWorks commented on June 13, 2024

Omg, @SidWorks there are some issues in your PR. You have deleted markdown files

Apologies @KINGSABRI 🙏
I did the commit without installing npm packages, I guess that what caused the issue.
image

Some files are missing because of that! I didn't not deleted or removed anything.
I am extremely sorry for this.
It can be fixed easily with next commit to a PR.
Please let me know on this 🙏

from rubyfu.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.