Comments (13)
It was two sides mistakes. Deleting a huge number of files was hard to review with the limited time I have.
I believe @noraj is working on it already, he's got sharp eyes
from rubyfu.
PS only the first 3000 files are displayed on the PR on github of the 4,570 files changed. as node_mobules is alphabetically before references.md we don't see it on the list, you have to check on the CLI.
from rubyfu.
Omg, @SidWorks there are some issues in your PR. You have deleted markdown files
from rubyfu.
@noraj thanks man for noticing this issue, we can upload it again. I've created a backup branch before accepting #48 PR. I was really skeptical about it
from rubyfu.
@noraj thanks man for noticing this issue
I'm like the watch tower of this project 😂
from rubyfu.
Yes you are :D . Really nice catch!
from rubyfu.
I've created a backup branch before accepting #48 PR. I was really skeptical about it
no need for a backup branch, a git commit can easily be reverted
from rubyfu.
by the way this page was remvoed too https://rubyfu.net/required-gems, I'm fixing it all
from rubyfu.
@KINGSABRI maybe you could add me to the project and set me as default reviewer (even if I don't have the permission to merge PRs)
from rubyfu.
@KINGSABRI Why did you reverted the revert that I made to fix the removed markdown files (babc7ea)? Because you re-removed them 😂
from rubyfu.
It was a bad move by a sleepy guy
from rubyfu.
It was a bad move by a sleepy guy
so should I re-re-revert it or you're doing it?
from rubyfu.
Omg, @SidWorks there are some issues in your PR. You have deleted markdown files
Apologies @KINGSABRI 🙏
I did the commit without installing npm packages, I guess that what caused the issue.
Some files are missing because of that! I didn't not deleted or removed anything.
I am extremely sorry for this.
It can be fixed easily with next commit to a PR.
Please let me know on this 🙏
from rubyfu.
Related Issues (16)
- Need more forensic
- Add task for Multi Languages HOT 1
- Can I translate this book to Chinese? HOT 1
- Brazilian portuguese Translation! HOT 1
- http auth error HOT 1
- to make Twitter API a better API for programmers HOT 5
- Inventory notification HOT 3
- references duplicate HOT 1
- Duplicate content / old content HOT 4
- `node_modules` folder should be excluded in a `.gitignore` HOT 1
- right place for images? HOT 1
- FAQS duplicate HOT 2
- add pipal HOT 3
- Gitbook sync HOT 1
- bogojoker.com/readline redirects HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rubyfu.