(non-Custom) Having platinum pieces increases monster evasion about elonapluscustom-gx

[Ruin0x11]

As far as I understand, this was an intentional change. It was added sometime in the gap between 1.90 and 2.05, but I'm not exactly sure when.

Here is the relevant code:

ElonaPlusCustom-GX/2.05-custom-gx/screen.hsp

Lines 5850 to 5857 in c68a7bc

	if ( cdata(CDATA_PLATINUM, cc) > 0 ) {
	if ( calcattackhit_arg1 == 0 ) {
	evade += (limit(sdata(SKILL_NORMAL_MEMORIZATION, tc) / 5, 1, 100) + 10) * (cdata(CDATA_PLATINUM, cc) / 10 + 1)
	if ( sorg(SKILL_NORMAL_MEMORIZATION, tc) > 0 ) {
	skillexp SKILL_NORMAL_MEMORIZATION, tc, 4, 0, 1000
	}
	}
	}

[Ruin0x11]

So after reading over this a bit more, I think I understand what might have happened. It seems that Ano reused the cdata slot for the platinum count and shared it with the Analysis counter introduced in 1.995. This makes sense since a higher Analysis counter is supposed to increase evasion. I think the reuse was because there weren't any more cdata slots available and the platinum count on NPCs was unused before.

However, it seems like this is accidentally being applied to the player for some reason.

[firecat6666]

Seems like a good way to fix this would be to add an extra condition to this function that checks the ID (offset 108 in cdata) of the attacking entity, if it's the player's ID then the entire thing is skipped. Only the player character can have platinum and no character can have an ID of 0 other than the player, except maybe in case of bugs, so I guess this should work fine 100% of the time.

[Ruin0x11]

Should be fixed in 2.10.1.0.