GithubHelp home page GithubHelp logo

Comments (6)

w2vy avatar w2vy commented on August 31, 2024

In the current master there are no references to IsDZelnodeActive, this issue can be closed

from fluxd.

blondfrogs avatar blondfrogs commented on August 31, 2024

@w2vy what about IsDFluxnodeActive?

from fluxd.

w2vy avatar w2vy commented on August 31, 2024

Good point, those I will look at to understand better and then we can talk about which can go.

from fluxd.

w2vy avatar w2vy commented on August 31, 2024

@blondfrogs
I reviewed all the IsDFluxnodeActive calls and they are all inside src/rpc/zelnode.cpp and defined in src/zelnode/zelnode.cpp

I went back to v5.2.0 (before I touched anything) and the instances of IsDZelnodeActive were the same.

I do see in main.cpp (ConnectBlock), miner.cpp (CreateNewBlock) and zelnode.cpp (rebuildfluxnodedb)
where the block height is compared to StartFluxnodePayments

So it seems IsDFluxnodeActive is only used in the RPC calls.

from fluxd.

blondfrogs avatar blondfrogs commented on August 31, 2024

@w2vy That sounds correct. Lets get together and see if we need them anymore.

from fluxd.

w2vy avatar w2vy commented on August 31, 2024

closed with PR#192

from fluxd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.