GithubHelp home page GithubHelp logo

Comments (2)

dkcumming avatar dkcumming commented on July 24, 2024 1

@anvacaru I believe the original rules that this module was replacing marked the rules as [simplification], and that I was getting slower results for performance if [simplification] was not added for this module. I concluded that it must be doing short circuit evaluation and avoiding evaluation LHS and RHS of the comparison if the attribute was added, but I don't have much confidence in that now. It is entirely possible that they ought not be marked [simplification].

I am not sure if the whole module should be marked as symbolic sorry, perhaps @ehildenb can offer more insight.

from evm-semantics.

anvacaru avatar anvacaru commented on July 24, 2024
`#lenOfHead(_)_EVM-ABI_Int_TypedArg`(`abi_type_tuple`(_))

The rule for #lenOfHead( #tuple(_) ) is missing. Maybe refactor all #lenOfHead rules into a single rule like:

rule #lenOfHead ( _ ) => 32
`#isStaticType(_)_EVM-ABI_Bool_TypedArg`(`abi_type_tuple`(_))

The rule for #isStaticType (#tuple ( TUPLE_ARGS )) is missing. We should add some logic here that does an OR on isStaticType() for each argument in TUPLE_ARGS.

  1. and 4. Both rules below are marked as simplification, so the llvm-backend issues Non-Exhaustive match on the operators <Gas, <=Gas for these cases (source here).
    rule #gas(_)  <Gas _       => false [simplification]
    rule _       <=Gas #gas(_) => true  [simplification]

Why do they have to be marked as simplification? Should the entire INFINITE-GAS module be marked as symbolic?
cc @ehildenb @dkcumming

from evm-semantics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.