Comments (6)
Yes, I plan to add bech32 support after Core does, both so I can be sure everything is finalized, and because it will give me an easy way to generate a ton of test vectors :)
from rust-bitcoin.
I think this is a reasonable thing to do, though I'm not sure how best to separate things. My uses tend to use pretty-much the whole crate except for the network/p2p stuff. Can you make a PR?
from rust-bitcoin.
OK, do you want to have them in the same repository, just separate crate?
My thinking for now: Things that may be reasonable to use without the blockchain/txses (addresses, base58, coin amount - not a separate type now but it may be good idea to create one), transaction-related data, blocks, network.
from rust-bitcoin.
Yes, same repo, just different crates.
From the network crate, the Network
enum is constantly useful (for distinguishing between testnet and mainnet) and is used frequently with the address structures. In turn the address structures heavily depend on the script de/serialization, which depends both on transaction-related data and on the consensus serializer (which is also in the network module IIRC).
from rust-bitcoin.
OK, I'll look at it during the weekend.
BTW any plans to add support for SegWit addresses? As far as I see it isn't there yet.
from rust-bitcoin.
I'm going to close this because it doesn't have any clear success condition. We have plans for some specific modules (contracthash stuff, anyway) to be pulled out of rust-bitcoin.
from rust-bitcoin.
Related Issues (20)
- `PartialOrd`/`Ord` on`CompactTarget` (and `block::Header`) are surprising
- Remove shebang from all shell scripts that are not meant to be run HOT 3
- `io::Write` is incompatible with `std::io::Write` HOT 3
- Update `.github/workflows/README.md` to mention shellcheck job
- Silent payments addresses (BIP352) HOT 10
- Make `consensus::encode` private
- `difficulty_float` is hardcoded to mainnet HOT 1
- 0.32 loses a bunch of functionality in `Address` HOT 22
- CI: Schemars job can use `extra_tests.sh` HOT 1
- How to get sighash_type from a transaction? HOT 8
- Are we enforcing the 520 stack element limit for segwit transactions? HOT 3
- Consider feature-gating `secp256k1` HOT 2
- Remove rustdocs build warnings HOT 8
- Fuzz failure in hashes/cbor HOT 2
- The `sha256t_hash_newtype!` call in the `taproot` module is unclear HOT 3
- Make `bitcoin::p2p::Magic::from_bytes` const function HOT 1
- Unused manifest key warning HOT 2
- What's the point of `Denomination::MilliSatoshi`? HOT 23
- `SegwitV0Sighash` is missing an `into_secp256k1_message` HOT 3
- Make the signing API use `Into<Message>`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rust-bitcoin.