GithubHelp home page GithubHelp logo

Comments (3)

oli-obk avatar oli-obk commented on June 22, 2024

this is "obsolete" right now since Options aren't allowed as hash map keys anymore.

The following test passes.

    #[test]
    fn test_encode_hashmap_with_option_key() {
        use std::io::Writer;
        use std::collections::HashMap;
        use std::fmt;
        let mut hm = HashMap::new();
        hm.insert(Some("hi"), true);
        hm.insert(None, false);
        let mut mem_buf = Vec::new();
        let mut encoder = Encoder::new(&mut mem_buf as &mut fmt::Writer);
        let result = hm.encode(&mut encoder);
        match result.err().unwrap() {
            EncoderError::BadHashmapKey => (),
            _ => panic!("expected bad hash map key")
        }
    }

I don't see how Option<String> could ever be encoded safely and trivially comprehensible. Or even Something like Option<SomeEnumWithAVariantNamedNone>.

from rustc-serialize.

oli-obk avatar oli-obk commented on June 22, 2024

@alexcrichton Should this be closed or should a way be found to allow this?

from rustc-serialize.

alexcrichton avatar alexcrichton commented on June 22, 2024

Ah yes thanks @oli-obk! I think that Json just won't be able to encode all possible Rust types.

from rustc-serialize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.