Comments (7)
Ugh. In addition to being wrong about the motivation for rust-lang/polonius#157, I was also wrong about what kind of leaper we need to express its rules for placeholder liveness. When we have a rule like:
live_to_dying_regions(origin1, origin2, point1, point2) :-
subset(origin1, origin2, point1), % main input
cfg_edge(point1, point2), % Leaper 1
(origin_live_on_entry(origin1, point2); placeholder_origin(origin1)), % Leaper 2
!origin_live_on_entry(origin2, point2). % Leaper 3
Leaper 2
(the disjunction) cannot propose any values because point2
is only bound on one side. In the current framework, it would have to be a ValueFilter
, and Leaper 1
would be exclusively responsible for proposing values. This is fine, since cfg_edge
should almost always be a better choice to propose than origin_live_on_entry
.
So basically, all that's needed is to implement an adapter that can take two ValueFilter
s and OR them together. The Leaper
interface is still not suitable for this, but the idea should be pretty easy to implement manually. At some point we'll want to implement caching like in #35 as well.
from datafrog.
@regexident Is this something that interests you? I think it's feasible, but definitely not trivial. I'm willing to help, of course. We should wait for @lqd to confirm that rust-lang/polonius#157 is still the way forward, and that this would actually help them.
from datafrog.
We unfortunately didn't manage to talk about rust-lang/polonius#157 at the last sprint, but hopefully we may be able to at the next one. (It's also still WIP in that it also lacks the required antijoins that are currently implicit: there are more details in the PR description).
It looks like the correct way forward to me too. The maintainability of these manual disjunctive queries is its main drawback, and that would be greatly improved if datafrog offered an API like this issue suggests.
(Just for clarification to @ecstatic-morse, rust-lang/polonius#157 doesn't fix the "Location::All
problem" even though it's of course related to the domain of "things that are true at all points of the CFG". The PR would fix a small inefficiency in the liveness of placeholders by removing the materialization with disjunctive queries. The Location:All
problem -- whose name is not at all descriptive enough as you'll see -- is in rustc fact generation and unrelated to placeholders or liveness: when type ascription is involved, the outlives
relationships are emitted at all points in the CFG. Sometimes this OOMs for big CFGs with many subsets, sometimes this just causes many duplicates to be computed and propagated in the TC, just to be deduped at the next CFG point.)
from datafrog.
Ah, okay. I guess I conflated "placeholder origin is live at all points" with "placeholder origin subset constraint must hold at all points". It seemed like the first would help the second, since subset
constraints propagate when an origin is live, but we already make placeholder origins live everywhere (by generating a tuple for every point in the control-flow graph) and that hasn't solved rust-lang/polonius#24. My bad.
from datafrog.
Hey @regexident, let me know if you want to work on this. We will need the ability to compose ValueFilter
s as described in #38 (comment) going forward, but it'll take me another week or two to get around to it. I'm happy to write some corrected mentoring instructions if you're interested. This change shouldn't be too hard, but you'll need to do some refactoring to make caching work.
from datafrog.
Hey @ecstatic-morse,
sorry for not getting back to you in a more timely way. I'd love to give it a shot!
I would probably need some hand-holding/mentoring on the semantics side of things though as datafrog is my very first contact with Datalog.
from datafrog.
No worries. I'm not a model for availability myself.
Let's talk on Zulip.
from datafrog.
Related Issues (10)
- Unit tests
- bring this crate into conformance with compiler-team crate policy HOT 1
- `Relation::from_antijoin` is broken HOT 1
- CI no longer runs HOT 1
- Execution Result is different from racket datalog engine HOT 3
- Datafrog does not support early termination HOT 5
- Add simple profiling statistics
- Investigate the effect of "treefrog leapjoin"-ing more than one Variable HOT 2
- Add repo to Cargo.toml
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from datafrog.