Comments (9)
Bummer! I'll take a look in a little bit.
Also, I'm planning to start adding integration tests soon, so it will be harder to break the end-to-end experience.
from highfive.
Hmm...my local Highfive on my test repo works as expected, so something more subtle is going on. The error suggests you are putting Apache in front of Highfive. Is that right? Can you share the config file with me?
from highfive.
Other questions:
- When you go to https://github.com/rust-lang/rust/settings/hooks and click edit on the webhook, do you see anything useful in the Recent Deliveries section? Particularly the response tab. I can see stack traces in there in my test repo when things go wrong.
- Which version of Python (
/usr/bin/env python --version
) are you running Highfive with?
from highfive.
I'll take a look in a little bit.
Thanks!
The error suggests you are putting Apache in front of Highfive. Is that right?
Yes
Can you share the config file with me?
There's a few config files, not sure which will be useful, the only thing I thought might be relevant:
# apache2.conf
ScriptAlias /highfive/ /var/www/html/highfive/
there's no mention of highfive in the other config files that I can find
When you go to https://github.com/rust-lang/rust/settings/hooks and click edit on the webhook
No there was nothing interesting this time - just a 500 error, usually it's the first place I look for something useful
Which version of Python (/usr/bin/env python --version) are you running Highfive with?
2.7.12
from highfive.
I'm running Python 2.7.14. I also tried 2.7.10 and 2.7.11 since I had those lying around. I haven't tried 2.7.12, but it seems unlikely to be the cause.
I was able to rig up a working Apache setup to front my test Highfive, and it works.
Did you revert Highfive in production, @nrc? I see it's working in rust-lang/rust again. I've started trying making requests to what I'm guessing is the production Highfive to see if I can learn anything useful, but I'll need a payload for a PR from there (or I'll need to assemble one by hand). With it working, however, that's not a useful avenue right now.
from highfive.
Did you revert Highfive in production, @nrc?
I did, yeah.
My suspicion is that there is an issue finding the new Python file - payload.py. However, there doesn't seem to be a problem with irc.py, so I'm not really sure why there would be a problem, it might be that I'm done something dumb with my server setup.
from highfive.
That was my initial suspicion. I thought perhaps you were installing Highfive using setup.py, but that looks fine. Are you open to deploying again at some point (I guess the alternatives are never deploying again or undoing my commits)? When that happens, I can try doing was I was going above and maybe you can tar up the contents of /var/www/html/highfive/ (minus the config file).
from highfive.
Are you open to deploying again at some point
Yeah. My preference is to try and move Highfive to Rust infra and hope that this just works when we set everything up from scratch (and do it properly, rather than my amateurish attempts). If that doesn't work then it should be possible to give you access to the server once it is on better infra. I'm waiting on the infra team to help out with that, if it is going to take a while though, then I can re-deploy and we can try to figure out what is happening.
from highfive.
Sounds good. Thanks!
from highfive.
Related Issues (20)
- Add some local tests
- rust-highfive only warns about updated submodules when a PR is created HOT 4
- Remove jemalloc config
- `r? @rust-highfive` to reassign a review randomly (again) HOT 1
- naive startswith can cover wrong directories for "mentions" HOT 1
- directory choice only examines first two components HOT 1
- feature request: warn if src/test/ is modified without modifying compiler/ or src/librustdoc/ HOT 5
- Warn on change to targets HOT 1
- Please detect commits that mark an API as stable and display a warning
- highfive should not assign someone to their own PR HOT 3
- Warn when `r?`d username doesn't have `r+` rights
- Mention notifications for changes to subtrees HOT 8
- Add link to rustbot commands in first message
- Why is it written in Python? 👀 HOT 1
- Add repo link to the `rust-highfive` user account
- Update rust config to add wgs/projects
- Give helpful info with r? is invalid HOT 1
- highfives misses some PRs HOT 1
- no longer can assign specific users HOT 1
- Re-assigning can assign the current assignee HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from highfive.