Comments (6)
Yeah, it goes by email addresses and https://api.github.com/users/vberger doesn't have one specified, while the PR does use one.
from highfive.
More data:
(https://api.github.com/users/MatejLach vs. https://github.com/rust-lang/rust/pull/17510.patch)
I have a feeling the current implementation isn't quite enough for the high traffic Rust repo, at least compared to Servo, e.g. the contributors API endpoint is only returning the top 100 (despite the per_page=400
, which isn't quite enough anyway, we currently have 614!), meaning new contributors will get welcome messages until they've landed ~20 commits. One possible way to resolve this would be to store the emails from the git history; but statefulness is sad. :(
from highfive.
Actually I was wrong; it's not email but github-login based, but it's definitely the fact that it's only pulling the top 100 contributors that's messing us up here.
from highfive.
I hope I fixed this by handling pagination properly. I guess there might still be issues with username mismatch. Lets see if that is a problem...
from highfive.
Hopefully fixed by fcffc5d I'll leave this issue open for a while and close it if we get no new instances of this.
from highfive.
Haven't seen any false positives recently, so closing.
from highfive.
Related Issues (20)
- Add some local tests
- rust-highfive only warns about updated submodules when a PR is created HOT 4
- Remove jemalloc config
- `r? @rust-highfive` to reassign a review randomly (again) HOT 1
- naive startswith can cover wrong directories for "mentions" HOT 1
- directory choice only examines first two components HOT 1
- feature request: warn if src/test/ is modified without modifying compiler/ or src/librustdoc/ HOT 5
- Warn on change to targets HOT 1
- Please detect commits that mark an API as stable and display a warning
- highfive should not assign someone to their own PR HOT 3
- Warn when `r?`d username doesn't have `r+` rights
- Mention notifications for changes to subtrees HOT 8
- Add link to rustbot commands in first message
- Why is it written in Python? 👀 HOT 1
- Add repo link to the `rust-highfive` user account
- Update rust config to add wgs/projects
- Give helpful info with r? is invalid HOT 1
- highfives misses some PRs HOT 1
- no longer can assign specific users HOT 1
- Re-assigning can assign the current assignee HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from highfive.