GithubHelp home page GithubHelp logo

Comments (3)

bytesnake avatar bytesnake commented on September 6, 2024

Glanced at travis in ndarray and they run a test script for 1.37.0, stable, beta and nightly. I'm very much in favor of Clippy

from linfa.

quietlychris avatar quietlychris commented on September 6, 2024

I'm not sure how I feel about clippy for scientific programming. I know that it generally recommends more "idiomatic" code, but I've seen several suggestions from it, particularly around iterators, that take code that is perhaps slightly less technically idiomatic (but much easier to interpret and maintain for humans) and turn it into an absolute mess. Other times, of course, the suggestions are great.

If we do use clippy, I might suggest it not being using the clippy::all option, and instead choose a subset of them in the CI like just clippy::correctness and clippy::complexity, and then recommending that suggestions or changes from other lints be made in the Submission Guidelines in the README.

from linfa.

paulkoerbitz avatar paulkoerbitz commented on September 6, 2024

Great comments - thank you.

I've left clippy for a later PR - we can look into the changes then and (partially) have a final decision then.

from linfa.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.