User Who Hasn't Finished Onboarding Cannot Subscribe about speedrail

[mrandrewjbaker]

Can you verify that users who have user.finished_onboarding? == true are able to view this, and not specific to unfinished users? I don’t believe # and %23 are the issue. 🤔

[ryanckulp]

closing this as i believe it was handled recently by e21ea85 and what i stated previously about clicking "Save" inside Stripe's UI (very dumb i know).

[stets]

Can you verify that users who have user.finished_onboarding? == true are able to view this, and not specific to unfinished users? I don’t believe # and ‘%23` are the issue. 🤔

Users who have user.finished_onboarding? == true hit the modify_subscription function:

speedrail/app/controllers/billing_portal_controller.rb

Line 39 in 3c51d93

def modify_subscription

They do redirect properly.

Something else odd is that navigating directly to the /billing_portal route directly works, but clicking the Manage button, which goes to the same route, gives the failed behavior above where stripe is hung up (and the URL does not have the section after the #)

[stets]

I'm thinking this behavior may be intended -- looks like the billing_portal route should only be requested with a POST not a GET like is happening when the user skips the onboarding flow. Maybe the manage button could be reworked as a form only if the user's onboarding status is false

[ryanckulp]

@stets thanks for digging!

• everyone should be able to view Account page, in case they want to update their email/password
• clicking /billing_portal link on account page should simply create a Checkout session vs BillingPortal session
• the creation of a Checkout vs billing is handled by finished_onboarding? which will always be false if they have not done a successful Checkout (source)

[stets]

Thanks @ryanckulp -- that all makes sense

• clicking /billing_portal link on account page should simply create a Checkout session vs BillingPortal session
  This step is where I'm observing the behavior where things break.

That user who has not finished onboarding, hits the begin_subscription function, which should redirect them to session.url, however the back half of that URL is getting chopped off and stripe will just get hung up

[ryanckulp]

@stets after further review, i think the page hangs because you don't yet have a subscription "set," which should be happening in a background job.

drop the delay inside user.delay.set_stripe_subscription, run back through onboarding (sign up, create subscription) and verify if that fixes things. i may need to tweak how the background jobs boot up.

[stets]

drop the delay inside user.delay.set_stripe_subscription, run back through onboarding (sign up, create subscription) and verify if that fixes things. I may need to tweak how the background jobs boot up.

Hmm, I gave that a try but still no luck. Keeping delay and removing delay from that func, I get the same results. The user is indeed getting a stripe customer id and it's being updated in the db too.

I think this has to due with some weirdness with redirects and handling that billing_portal route. Maybe it is because we are GETing it from the Account Page (breaks) but POSTing to it from the /subscribe page 🤔

btw I don't really need this to work, I can work around it. just want to point it out as an edge case that could be unreliable within Speedrail

[ryanckulp]

the routes file handles both GET and POST so thats fine. but page will hang when there is no attached customer id when the portal opens. can you confirm there is a customer id?

further you’ll need to just click “save changes” inside the Stripe UI > portal settings, kinda strange. this must be done 1x before it works, but your rails server should tell you that in the browser on localhost.