Comments (2)
Hey @doyaaaaaken . Let me give some thoughts.
Please, refer https://httpstatuses.com/429
As for no, we're retrying requests with delay
based on invocationTimeout
and ratio
.
Getting 429 it is possible to retry using slightly different technique:
429 response MAY have a Retry-After: xxx
header.
We can use this number (xxx
) as a time before next retry.
Also, it m/b a good idea to introduce maxDelayTime
from kohttp.
Hi, I tried to work on this. And I have one question.
Which does this issue mean?
- When we get 429 response from external service, we should regard it as error and retry (or stop is better?) to request.
- When we reach to max retry attempt's count, we should handle this response as 429 status code. (Even if the response code is not 429)
If the meaning is 1, should we simply add 429 on errorStatuses
at below code?
If the meaning is 2, I guess we could not rewrite response code because Response.code
is final int
field.
(And also I think we shouldn't rewrite status code inside kohttp library. It's out of developer's expectation.)
from kohttp.
Related Issues (20)
- Sample code on how to set a read/connect timeout HOT 4
- [kohttp-docs] Add a clear example configuring and passing client to httpXXX { }
- [Better engenering] migrate to Jitpack release?
- [kohttp-docs] missing kohttp-jackson module examples and description
- [kohttp-moshi] Introduce integration
- [samples][spring] move example from abstract requests to weather localizer HOT 2
- Can not build with AS 3.5.2
- My APP crash HOT 2
- How can I make this code not so awful? HOT 2
- SSL configuration not working for JDK 9+ HOT 3
- [android] Library proguard config
- [kohttp] Optimise project imports
- [kohttp-backend] Async http client
- possible performance problems HOT 1
- Bump kohttp version to work with latest Android HOT 6
- Response doc is misleading - .asJson is missing HOT 1
- Function to in FormBodyBuilder with nullable type has unexpected behavior HOT 2
- How can I use kohttp for this specific curl command?
- Support Upload And Download Listener
- url is double encoded if used with url(encodedUrl)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kohttp.