GithubHelp home page GithubHelp logo

Comments (2)

rybalkinsd avatar rybalkinsd commented on May 27, 2024 1

Hey @doyaaaaaken . Let me give some thoughts.

Please, refer https://httpstatuses.com/429

As for no, we're retrying requests with delay based on invocationTimeout and ratio.
Getting 429 it is possible to retry using slightly different technique:
429 response MAY have a Retry-After: xxx header.
We can use this number (xxx) as a time before next retry.

Also, it m/b a good idea to introduce maxDelayTime

from kohttp.

doyaaaaaken avatar doyaaaaaken commented on May 27, 2024

Hi, I tried to work on this. And I have one question.

Which does this issue mean?

  1. When we get 429 response from external service, we should regard it as error and retry (or stop is better?) to request.
  2. When we reach to max retry attempt's count, we should handle this response as 429 status code. (Even if the response code is not 429)

If the meaning is 1, should we simply add 429 on errorStatuses at below code?

private val errorStatuses: List<Int> = listOf(503, 504)

If the meaning is 2, I guess we could not rewrite response code because Response.code is final int field.
(And also I think we shouldn't rewrite status code inside kohttp library. It's out of developer's expectation.)

from kohttp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.