GithubHelp home page GithubHelp logo

Comments (6)

dtropanets avatar dtropanets commented on May 27, 2024

Hey. I'd say this is an issue, because it is not obvious that url extension ignores parameters. In our case, we passed the URL provided from the API and lost parameters, resulting in failed request.

from kohttp.

rybalkinsd avatar rybalkinsd commented on May 27, 2024

Hi @dtropanets , could you please submit a code sample? It would be very helpful for us to see the concrete problem. We're checking our options to clarify url { } logic

from kohttp.

dtropanets avatar dtropanets commented on May 27, 2024

What I meant is if you receive a URL from some API ("https://api.github.com/users/whatever?client_id=xxxx") and pass it to the url(), client_id=xxxx parameter will be ignored, because url() doesn't add parameters to the builder. This is not obvious, since user is expecting that the whole url will be used for request. I think, using both url() and param { } as a source of parameters is perfectly fine. As example, user can have some url (again, "https://api.github.com/users/whatever?client_id=xxxx") as a base for requests and then add additional params using param { }.

I can make a PR with this change, it should be quite straightforward.

from kohttp.

rybalkinsd avatar rybalkinsd commented on May 27, 2024

I see, make sense. Added some notes and a checklist to the issue description.
PRs are always welcome!

from kohttp.

rybalkinsd avatar rybalkinsd commented on May 27, 2024

https://github.com/rybalkinsd/kohttp/tree/fix/94-url-params here are several fixes over the whole codebase according to this fix. The plan is to merge them together with @dtropanets 's PR

from kohttp.

rybalkinsd avatar rybalkinsd commented on May 27, 2024

0.10.0

from kohttp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.