Comments (6)
Hey. I'd say this is an issue, because it is not obvious that url
extension ignores parameters. In our case, we passed the URL provided from the API and lost parameters, resulting in failed request.
from kohttp.
Hi @dtropanets , could you please submit a code sample? It would be very helpful for us to see the concrete problem. We're checking our options to clarify url { }
logic
from kohttp.
What I meant is if you receive a URL from some API ("https://api.github.com/users/whatever?client_id=xxxx") and pass it to the url()
, client_id=xxxx
parameter will be ignored, because url()
doesn't add parameters to the builder. This is not obvious, since user is expecting that the whole url will be used for request. I think, using both url()
and param { }
as a source of parameters is perfectly fine. As example, user can have some url (again, "https://api.github.com/users/whatever?client_id=xxxx") as a base for requests and then add additional params using param { }
.
I can make a PR with this change, it should be quite straightforward.
from kohttp.
I see, make sense. Added some notes and a checklist to the issue description.
PRs are always welcome!
from kohttp.
https://github.com/rybalkinsd/kohttp/tree/fix/94-url-params here are several fixes over the whole codebase according to this fix. The plan is to merge them together with @dtropanets 's PR
from kohttp.
0.10.0
from kohttp.
Related Issues (20)
- Sample code on how to set a read/connect timeout HOT 4
- [kohttp-docs] Add a clear example configuring and passing client to httpXXX { }
- [Better engenering] migrate to Jitpack release?
- [kohttp-docs] missing kohttp-jackson module examples and description
- [kohttp-moshi] Introduce integration
- [samples][spring] move example from abstract requests to weather localizer HOT 2
- Can not build with AS 3.5.2
- My APP crash HOT 2
- How can I make this code not so awful? HOT 2
- SSL configuration not working for JDK 9+ HOT 3
- [android] Library proguard config
- [kohttp] Optimise project imports
- [kohttp-backend] Async http client
- possible performance problems HOT 1
- Bump kohttp version to work with latest Android HOT 6
- Response doc is misleading - .asJson is missing HOT 1
- Function to in FormBodyBuilder with nullable type has unexpected behavior HOT 2
- How can I use kohttp for this specific curl command?
- Support Upload And Download Listener
- url is double encoded if used with url(encodedUrl)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kohttp.