GithubHelp home page GithubHelp logo

Comments (9)

sa-si-dev avatar sa-si-dev commented on July 22, 2024 1

@gnbm no need to rollback the privious change.
I have checked-in the fix for this issue. But it hasn't released yet.

Fix commit
fd407b8

from virtual-select.

sa-si-dev avatar sa-si-dev commented on July 22, 2024 1

@gnbm This issue has been fixed in the release v1.0.40

from virtual-select.

sa-si-dev avatar sa-si-dev commented on July 22, 2024 1

Could you please create a new release with this issue fix only

@sa-si-dev Sure, I'll try to do it this week and ask for your validation since I still can't run the tests or the validate command without getting tons of errors.
Would it be possible to also have your help on fixing these issues: #162 / #169 / #244? They are having some impact and I don't know the library enough yet to be able to quickly fix them. It would be really helpful!

@gnbm I will fix other issues in the future release.

from virtual-select.

gnbm avatar gnbm commented on July 22, 2024

@sa-si-dev Created this PR to roll back the unwanted behaviour that was introduced.

Important Note:
The original issue that the PR wanted to address will still occur so it will need to be done differently and here maybe you could quickly fix this differently since you know much better all the component lifecycle and events.

from virtual-select.

gnbm avatar gnbm commented on July 22, 2024

@sa-si-dev Will run some tests and will give you some feedback. Meanwhile, closed the PR. Cheers

from virtual-select.

gnbm avatar gnbm commented on July 22, 2024

@sa-si-dev Just a follow-up. Just run a batch of tests with the change you did in the commit and it works perfectly.
Do you have a release planned?
Thank you!

from virtual-select.

sa-si-dev avatar sa-si-dev commented on July 22, 2024

@sa-si-dev Just a follow-up. Just run a batch of tests with the change you did in the commit and it works perfectly.
Do you have a release planned?
Thank you!

Could you please create a new release with this issue fix only.

from virtual-select.

gnbm avatar gnbm commented on July 22, 2024

Could you please create a new release with this issue fix only

@sa-si-dev Sure, I'll try to do it this week and ask for your validation since I still can't run the tests or the validate command without getting tons of errors.
Would it be possible to also have your help on fixing these issues: #162 / #169 / #244? They are having some impact and I don't know the library enough yet to be able to quickly fix them. It would be really helpful!

from virtual-select.

gnbm avatar gnbm commented on July 22, 2024

Could you please create a new release with this issue fix only

@sa-si-dev Sure, I'll try to do it this week and ask for your validation since I still can't run the tests or the validate command without getting tons of errors.
Would it be possible to also have your help on fixing these issues: #162 / #169 / #244? They are having some impact and I don't know the library enough yet to be able to quickly fix them. It would be really helpful!

@gnbm I will fix other issues in the future release.

@sa-si-dev That would be amazing since the impacts on my case are quite big. Cheers

from virtual-select.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.