Comments (14)
@abenhamdine feel free to do a PR to fix that (keep in mind that the use case for accessibility needs to be fixed as well)
from virtual-select.
@abenhamdine could you please share a codepen with that use case?
from virtual-select.
@abenhamdine could you please share a codepen with that use case?
I will try to find time to do it.
But I think any case where you init the select without options, then provide the options later, should exhibit the bug.
from virtual-select.
@abenhamdine could you please share a codepen with that use case?
I will try to find time to do it. But I think any case where you init the select without options, then provide the options later, should exhibit the bug.
Could you replicate it here? Maybe I'm missing something and you can go from that example and fork it
from virtual-select.
@abenhamdine any update on this?
from virtual-select.
When I try to use allowNewOption with an empty option, it also causes the search input to be disabled. Could you please enable the search input when allowNewOption is true? it worked perfectly before version 1.0.41
from virtual-select.
When I try to use allowNewOption with an empty option, it also causes the search input to be disabled. Could you please enable the search input when allowNewOption is true? it worked perfectly before version 1.0.41
@funnygod I would say it would be better to create a separate issue and include a working example for your scenario that is not the same as reported here.
I might also be missing something but I'm not being able to replicate what you mentioned.
from virtual-select.
When I try to use allowNewOption with an empty option, it also causes the search input to be disabled. Could you please enable the search input when allowNewOption is true? it worked perfectly before version 1.0.41
@funnygod I would say it would be better to create a separate issue and include a working example for your scenario that is not the same as reported here. I might also be missing something but I'm not being able to replicate what you mentioned.
Thank you, I will open a new issue.
from virtual-select.
@abenhamdine any update on this? Did you get the chance to create a sample and/or test this with the latest version?
from virtual-select.
Hi @abenhamdine
I had a similar issue to #319 so I decided to look at the code and try to fix this.
Created a draft PR with a possible solution, could you please help validate this before opening the PR itself (I'm just having some issues running the tests, where 3 are failing, even though I can't manually get any error but would like double check to mitigate the risk of introducing any regression issue)? Does it help on this particular issue, since I was not able to reproduce it?
You'll need to get my branch, build it and use the Dev Tools overrides.
from virtual-select.
Hi @abenhamdine I had a similar issue to #319 so I decided to look at the code and try to fix this. Created a draft PR with a possible solution, could you please help validate this before opening the PR itself (I'm just having some issues running the tests, where 3 are failing, even though I can't manually get any error but would like double check to mitigate the risk of introducing any regression issue)? Does it help on this particular issue, since I was not able to reproduce it? You'll need to get my branch, build it and use the Dev Tools overrides.
hi, thx to try fix this
I assume this particular change aims to fix this issue : https://github.com/sa-si-dev/virtual-select/pull/325/files#diff-c05424d9560afeceb2af0a702e65eceb831b7a202b14940261f43dec5a4b285eR2784 ?
from virtual-select.
Hi @abenhamdine I had a similar issue to #319 so I decided to look at the code and try to fix this. Created a draft PR with a possible solution, could you please help validate this before opening the PR itself (I'm just having some issues running the tests, where 3 are failing, even though I can't manually get any error but would like double check to mitigate the risk of introducing any regression issue)? Does it help on this particular issue, since I was not able to reproduce it? You'll need to get my branch, build it and use the Dev Tools overrides.
hi, thx to try fix this I assume this particular change aims to fix this issue : https://github.com/sa-si-dev/virtual-select/pull/325/files#diff-c05424d9560afeceb2af0a702e65eceb831b7a202b14940261f43dec5a4b285eR2784 ?
Hi. Since I was not able to reproduce it I just wanted to understand if you could test it for your scenario since you never ended up sharing a sample with this issue.
from virtual-select.
I just have tested version 1.0.43 and this issue is kind of mitigated, but still occurs : search input is still disabled when the user open the dropdown at first time, but when the dropdown is closed then reopened, the search input is now enabled.
from virtual-select.
I just have tested version 1.0.43 and this issue is kind of mitigated, but still occurs : search input is still disabled when the user open the dropdown at first time, but when the dropdown is closed then reopened, the search input is now enabled.
As mentioned, I was not able to replicate it so to fix it you can give it a try since I won't have time to dedicate to this atm.
If I can help with something I'll try to validate it. But it would be important to have a sample where that can be replicated, like other members did
from virtual-select.
Related Issues (20)
- onChange event is fired twice when you change value after using search HOT 6
- Limit minimum number of selected values
- Destroy method does not properly remove the event listeners HOT 1
- Dropbox has blurry borders in Chromium browsers HOT 2
- when using server search, disableSelectAll doesn't work HOT 6
- When using popup mode and preselected values make the focus go to the dropdown when entering the screen
- The "disabled" property doesn't account for the tabindex. HOT 7
- Inline Style Css Properties is not Showing HOT 1
- Add property in the documentation HOT 1
- deselectAllOnlyVisible feature HOT 1
- Broken display of options with icons HOT 4
- Add classes to button HOT 3
- The search input is disabled when allowNewOption is set to true and the options are empty. HOT 5
- Search Feature Unresponsive After Setting an Empty List of Options HOT 3
- Scrolling is broken when a custom onServerSearch function Is defined HOT 10
- The reset() method is triggering on change event and causing an infinite loop when used on certain contexts HOT 1
- Custom values in onServerSearch are not respected HOT 1
- Scrolling gets stuck in Safari when multiple select has options selected HOT 2
- why i get the wrong in browser console: index.vue:62 Couldn't initiate Virtual Select HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from virtual-select.