GithubHelp home page GithubHelp logo

Comments (6)

saadq avatar saadq commented on September 25, 2024 1

Hmm, will look into this. But just to clarify – lynt does not use your tslint.json. It is basically a wrapper around TSLint and it uses its own config for it. The full TSLint config that is generated is here: https://github.com/saadq/lynt/blob/master/src/tslint/config.ts

If you'd rather use your own rules with your own config, you're probably better off just sticking with TSLint.

With that said, I'm going to take a look at these rules and see what could be causing this issue. Let me know if you find anything strange in there in the mean time!

from lynt.

whyboris avatar whyboris commented on September 25, 2024 1

I think you're correct about 'no-unnecessary-type-assertion'
I removed the line 'no-unnecessary-type-assertion': true, from node_modules/lynt/lib/tslint/config.js (manual hack) and re-ran the npm run lynt (pacagke.json command has --typescript --fix) and it no longer removed the type assertions!
Your file: https://github.com/saadq/lynt/blob/master/src/tslint/config.ts#L80

ps -- using lynt removed about 300 unused imports in our codebase ❤️ 🙌 ❤️

pps - After lynt removed the unused imports, it left behind some blank lines, resulting in errors when I was running our regular linter: it complained no-consecutive-blank-lines. Sorry to overload this issue -- please let me know if you'd like me to open a new issue with just this comment 👍

from lynt.

saadq avatar saadq commented on September 25, 2024 1

This rule has been removed entirely as of v0.5.0. Release notes: https://github.com/saadq/lynt/releases/tag/v0.5.0

from lynt.

saadq avatar saadq commented on September 25, 2024

Thinking it might be this

from lynt.

saadq avatar saadq commented on September 25, 2024

lynt just uses TSLint's --fix flag, so I think the issue for that would need to be opened in the TSLint repo.

from lynt.

saadq avatar saadq commented on September 25, 2024

But let me know if for some reason this only happens when you run lynt --typescript --fix and not tslint --fix.

from lynt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.