Request body in save_info view is bytes object about django-webpush

[safwanrahman]

Yap. In python 3.x, by default it is byte rather than string. In python 2.x, its string.
I dont know python 3.x and I think the approach you have taken, is suitable for both python 2.x and python 3.x

[arogachev]

I investigated issue more deeply. It's not about request.body, it's always a byte string. The reason is json.loads() in Python 3 allows only strings:

if not isinstance(s, str):
    raise TypeError('the JSON object must be str, not {!r}'.format(s.__class__.__name__))

Check this SO question for example:

The request body, request.body, is a byte string. In Python 3, json.loads() will only accept a unicode string, so you must decode request.body before passing it to json.loads().

body_unicode = request.body.decode('utf-8')
body_data = json.loads(body_unicode)

In Python 2, json.loads will accept a unicode string or a byte sting, so the decode step is not necessary.

So decoding to unicode string will work for both Python 2 and 3 (even for version 2 is not required), also this is shorter and more elegant solution in my opinion.

But it will be better to have some tests.