GithubHelp home page GithubHelp logo

Comments (3)

safwanrahman avatar safwanrahman commented on May 23, 2024

Thanks for the issue. I will look over into it. Seems like a improvement that should be made. It needs some documentation also!

from django-webpush.

arogachev avatar arogachev commented on May 23, 2024

I think we should use existing manifest.json file or create new one manually (if it not exists) and add it to template:

<link rel="manifest" href="{% static 'core/js/manifest.json' %}">

Additionally adding one line to template is not a problem. gcm_sender_id needs to be added anyway (either to settings or manifest.json). By the way, it's better to not change name to GCM_ID in settings and leave it as gcm_sender_id.

from django-webpush.

safwanrahman avatar safwanrahman commented on May 23, 2024

@arogachev manifest.json is no longer needed in webpush for chrome. Thanks a lot for the issue and discussion

from django-webpush.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.