GithubHelp home page GithubHelp logo

Comments (5)

sahat avatar sahat commented on May 5, 2024

This is a good approach. The first problem that I ran into was redirectTo being set to:

/fonts/fontawesome-webfont.woff

I was able to get around it by modifying the regex:

if (/^(auth|login|logout|signup|fonts)$/.test(path)) return next();

But this is not the best solution. What if someone adds a font folder, or what about brand logo image that is fetched on each request? I am not very good with regular expressions, could you modify that code so it ignores anything with a file extension. Perhaps there are other edge cases I am missing?

from hackathon-starter.

ammit avatar ammit commented on May 5, 2024

Use this middleware after express.static,

from hackathon-starter.

ammit avatar ammit commented on May 5, 2024

@sahat If there's no problem moving express.static right on the top after app.set('view engine')
then we can use this middleware after passport.session. I got it working on my local setup. What do you think ?

from hackathon-starter.

sahat avatar sahat commented on May 5, 2024

I have placed the middleware between static and router, it seems to work fine. Will need to run more tests to see if there are side-effects of this new change before pushing to master.

app.use(express.static(path.join(__dirname, 'public'), { maxAge: week }));
app.use(function(req, res, next) {
  if (req.method !== 'GET') return next();
  var path = req.path.split('/')[1];
  if (/(auth|login|logout|signup)$/.test(path)) return next();
  req.session.redirectTo = req.path;
  next();
});
app.use(app.router);

from hackathon-starter.

sahat avatar sahat commented on May 5, 2024

Thanks @ammit. I have pushed this change to master branch. 208dd79

from hackathon-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.