perl script to convert cunit to junit exits with error code 1 when producing XML of failed runs about libiscsi

[mykaul]

Hmm, I guess this line explains it:
exit(1) if ($nfailed > 0);

[jonhermansen]

Yes, I also encountered this. In some cases, this behavior may be desirable. You have a few options for dealing with this in a Jenkins job:

Run the cunit-to-junit.pl script like this:

perl cunit-to-junit.pl || true

or

set +e
perl cunit-to-junit.pl
set -e

and possibly

if [ perl cunit-to-junit.pl ]; then
  echo "no tests failed"
else
  echo "some test(s) failed"
fi

depending on the shell you're using.

[sahlberg]

Can you send me a small patch to add this information to the manpage ?

On Tue, Mar 25, 2014 at 11:35 AM, Jon Hermansen [email protected]:

Yes, I also encountered this. In some cases, this behavior may be
desirable. You have a few options for dealing with this in a Jenkins job:

Run the cunit-to-junit.pl script like this:

perl cunit-to-junit.pl || true

or

set +e
perl cunit-to-junit.pl
set -e

and possibly

if [ perl cunit-to-junit.pl ]; then
echo "no tests failed"
else
echo "some test(s) failed"
fi

depending on the shell you're using.

Reply to this email directly or view it on GitHubhttps://github.com//issues/102#issuecomment-38603264
.

[jonhermansen]

diff --git a/cunit-to-junit.pl.orig b/cunit-to-junit.pl
index 7cf9320..41e3cfc 100644
--- a/cunit-to-junit.pl.orig
+++ b/cunit-to-junit.pl
@@ -226,4 +226,3 @@ foreach my $s (@suites)
 }

 print "$0: ran $nrun tests, $nfailed failed\n";
-exit(1) if ($nfailed > 0);

[sahlberg]

I meant a patch to doc/iscsi-test-cu.xml :-)

To add the useful parts of this thread to the manpage.
I added some text to discuss the return code from the script and the patch
above.

Since I don't use --xml myself, I am the wrong person to do the authorative
writeup on this.
Please have a look at the manpage and let me know if there is something
that should be added.

On Tue, Mar 25, 2014 at 12:47 PM, Jon Hermansen [email protected]:

diff --git a/cunit-to-junit.pl.orig b/cunit-to-junit.pl
index 7cf9320..9182ff0 100644
--- a/cunit-to-junit.pl.orig
+++ b/cunit-to-junit.pl
@@ -226,4 +226,4 @@ foreach my $s (@suites)
}

print "$0: ran $nrun tests, $nfailed failed\n";
-exit(1) if ($nfailed > 0);
+#exit(1) if ($nfailed > 0);

Reply to this email directly or view it on GitHubhttps://github.com//issues/102#issuecomment-38611608
.

[sahlberg]

I have updated the manpage with the relevant information about the return code from the script and how to change it if different semantics are wanted.

Closing for now, feel free to reopen issue if there are text you want added to the manpage.