GithubHelp home page GithubHelp logo

Comments (4)

patrys avatar patrys commented on May 22, 2024

Why should we disable that? You don't have to use Facebook for the rest of your life.

from saleor.

Acrobot avatar Acrobot commented on May 22, 2024

I see, in this case, we should probably have a page that lets you set your password for the account. If you're logging in via OAuth, you are not asked to set your password, which means that you can change the e-mail, but (this is based on guessting, I haven't tested it, as I don't have an SMTP server on my local PC) you are not going to be asked for a new password. Also - to change the password, you need to enter the old password - which, in case of OAuth, should never exist.


Rozumiem - z Facebooka nie trzeba zawsze korzystać. Jednak przy logowaniu za pomocą OAuth, nie podajemy naszego hasła (poprawnie), co oznacza, że kiedy zmienimy e-mail (przypuszczam - nie mam serwera SMTP na komputerze) nie jesteśmy proszeni o zmianę hasła - a wtedy zostajemy z kontem z e-mailem, ale bez hasła. Swoją drogą, do zmiany hasła potrzebne jest stare hasło - którego, w przypadku OAuth, nie ma.

PS Wydaje mi się jednak, że nie powinniśmy mieszać OAuth ze zwykłymi kontami. Jeśli ktoś chce przestać korzystać z Facebooka, no cóż, nie powinien używać jego OAuth. Ewentualnie, możnaby było dodać przycisk do migracji OAuth -> Konto serwisowe.

from saleor.

patrys avatar patrys commented on May 22, 2024

Whether you reset your password or email, you are actually offered to create a password. The process is not perfect yet, but it's there. Resetting a password requires you to click an email link and thus does not require the old password.

from saleor.

Acrobot avatar Acrobot commented on May 22, 2024

I'm sorry then - you can disregard most of my post. However, changing a password from the /account/change_password/ page requires the old password.

Have a nice day and sorry for bothering you!

from saleor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.