[BUG] Doubts and possible issue with translations setup about pwa-kit

[vmarta]

Should we be running the translation scripts (i.e. extract-default-translations) every time a localisation is added/modified?

Not only that extract script, but also the compile one. Because retail-react-app would try to grab the compiled translations:

pwa-kit/packages/template-retail-react-app/app/utils/locale.js

Line 26 in cf16f46

module = await import(`../translations/compiled/${targetLocale}.json`)

So for convenience, please run this script instead (to run both the extract and compile): npm run build-translations.

(But of course, feel free to call each script individually, as long as the translations get compiled at the end)

[vmarta]

About the inconsistency you found in the test setup, the DEFAULT_LOCALEs should match. At some point, it was changed from en-GB to en-US. But the tests were probably not updated accordingly. I'll look into this further.

[git2gus]

This issue has been linked to a new work item: W-12946757

[breadadams]

Hey @vmarta , thanks for your response.

Not only that extract script, but also the compile one

Yeah my bad, I meant the "full flow" of both scripts, so perfect 👍 .

[...] the DEFAULT_LOCALEs should match. At some point, it was changed from en-GB to en-US. But the tests were probably not updated accordingly. I'll look into this further.

Ok great, I look forward to hearing news on the matter.