GithubHelp home page GithubHelp logo

Comments (4)

bfeister avatar bfeister commented on June 10, 2024

Hi there. Thanks for reporting, but we will need to clarify exactly what the problem is before we can accept this issue.

I'm going to attempt to rephrase the issue, please tell me if this is correct.

"I want pwa-kit to parse default SFRA urls (for example, those that include .html in the URL path, which in SFRA include categories and products)."

Is this an accurate rephrasing of your question?

If "yes", then we have considered this. Not sure when it will be fixed, but @natemarcus and I can discuss priority and follow up

I want to be clear on one important point: SFRA urls are highly configurable, so capturing all of the different potential URL permutations will ultimately require an extra API call. For this reason, our internal guidance for customers with highly customized URL schemas is that they change their URL structure because the cost of not doing so will be latency and slightly degraded site performance from these extra API calls

from pwa-kit.

bfeister avatar bfeister commented on June 10, 2024

To answer the question "is it possible to use .html in a pwa-kit URL path?" (If this is your question), then the answer is yes.

You need to modify the routes.jsx file to achieve this.

You can change this line
https://github.com/SalesforceCommerceCloud/pwa-kit/blob/develop/packages/template-retail-react-app/app/routes.jsx#L86

To the following if you want a product detail URL that ends with .html

path: '/product/:productId.html',

Or something close to this

from pwa-kit.

SushmithaA18 avatar SushmithaA18 commented on June 10, 2024

Hi @bfeister
In SFRA we are extending the functionality of models & scripts of base files, likewise, can we extend the functionality of pwa-kit base-files/code.

from pwa-kit.

bfeister avatar bfeister commented on June 10, 2024

@SushmithaA18 it sounds like you're a very early in your exploration and journey with the pwa kit project. We are glad you're here, I'm reaching out!

The very short answer to your question is, yes, absolutely the project is extensible. In many ways, more so than SFRA.

GitHub issues (where we are having this conversation now) is a place for bug reports, not really for questions.

The good news is we have multiple channels for asking questions:

https://unofficialsfcc.com/

Please follow up there with questions, I'm going to close this issues since GitHub is not the place for the beginning of your journey in learning the platform

from pwa-kit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.