Comments (7)
Okay, so right now the change would be (some way) even worse. 😅
But good to know and I think that in V2 an authenticator like that would make sense.
from saloon.
Ooh yeah that could be good! So it just adds a query parameter with the key and value?
from saloon.
Exactly. Wasn't sure about naming but yeah, like ?key=abc123
from saloon.
I can definitely add that in - but I do think defaultQuery on the connector is a good approach too, you would just need to accept the API key through the constructor of the connector.
from saloon.
Yeah, doing it right now that way. But The authenticator feels better. And one question regarding priority.
If I use defaultQuery()
to define key=1
, the query authenticator with key=2
and in the request itself also defaultQuery()
with key=3
- which one would be used? My hope would be that the authenticator has priority over both defaultQuery()
methods - as it explicitly calls addQuery()
. 🤔
from saloon.
I think that defaultQuery will take priority over the authenticator unfortunately. This is something that has been looked over a lot in v2 and the authenticator is basically the last thing in v2. Apologies
from saloon.
This has now been added to the v2 branch!
from saloon.
Related Issues (20)
- Rate Limit Plugin: Issue with 'allow(1)->everySeconds(1)->sleep()' Exceeding One Request per Second
- Inteliphense cannot recognize the merge() method on request HOT 3
- Connector default headers overwrite request body headers HOT 1
- Remove authentication on a specific request HOT 5
- Some properties are removed from the response body
- Using non-standard HTTP methods HOT 2
- Generating Documentation Files for GPT on ChatGPT HOT 4
- Tests using Fixtures with custom Authenticators record incorrect response HOT 1
- async request with multi connector HOT 1
- Allow partial overriding of fixtures HOT 2
- Asserting a request is sent by closure parameter HOT 1
- Connector object() throws an exception but json returns null|object? HOT 1
- Feature Request: Requests have the ability to return a Colleciton HOT 1
- Connector does not support `defaultBody()`? HOT 3
- Request class cannot accept `$query` property in constructor HOT 3
- Possible to Use Multiple Instances of Same Request in Single Test? HOT 1
- Override Connector defaultHeaders() in request HOT 5
- Offloading a Listener for SentSaloonRequest events to a queue returns error HOT 3
- Pagination: `currentPage` doesn't align with `page` HOT 5
- Additional requests with the main request HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from saloon.