Non-generic Dictionary type for S# compability about saltarellecompiler

[erik-kallen]

The problem is that the plain Dictionary cannot implement interfaces, because doing so would require extension of Object.prototype which is quite intrusive (and the IDictionary.TryGetValue member cannot be reasonably implemented even if we accept an extension of Object.prototype).

In S# (I think), the IDictionary interface isn't possible to implement in a working fasion due to these issues.

As a replacement for the S# Dictionary(params object[]) constructor, use JsDictionary.GetDictionary(new { param1 = "value1", param2 = 10 }).

I am not too happy about introducing compiler support for the mentioned constructor, as it would require quite a lot of code for this single feature (a new ConstructorScriptSemantics.ImplType, with handling of that, tests, and also the metadata importer). However, your idea of an mscorlib helper method is not bad, neither too much work.

[volkanceylan]

So, is it ok to add a new constructor to JsDictionary like

[InlineCode("ss.setDictionaryInitialValues({initialValues})]
public JsDictionary(params object[] initialValues)
{
}

One could use this InlineCode with his own imported objects.

I'll work on it if you'll agree.

[erik-kallen]

Yes, I think that is a good idea (but perhaps with a shorter method name).

I haven't worked with S# in a while, why would one want to use that on his own imported objects? Does S# support adding a constructor with this signature to any object and it will be treated as an object initializer?

[erik-kallen]

Actually, we could add an if in the ScriptSharpMetadataImporter to apply this InlineCodeAttribute automatically for any .ctor(params object[] args) constructor in an [Imported] type.

[volkanceylan]

Yes it did and initial jquery plugin templates for ScriptSharp had such constructors for plugin Option objects.

It is even still used in current jQuery.UI implementation of S#

Example:

https://github.com/nikhilk/scriptsharp/blob/master/src/Libraries/jQuery/jQuery.UI/PositionOptions.cs

So this constructor type is not only for Dictionary, but all imported objects.

[volkanceylan]

Don't take me wrong, i think Saltarelle works great, and such incompabilities is do to some missing/incosistent parts in S#'s side. But, if you care about adoptation rate, porting an existing code from S# should require minimum changes. As, not all users will be as insistent as me. Most will try your compiler, get some errors, think it doesn't work like it should, and move on.

[erik-kallen]

I agree with you on that, and I think your idea with an mscorlib helper will solve this issue for us (as I said, we can auto-apply this attribute in the metadata importer). I just didn't come up with the idea myself.

[erik-kallen]

params object[] constructors are implemented and will be supported in 1.2.1