Window.Location has no setter about saltarellecompiler

[erik-kallen]

This is from Script#. I guess the reason is that the type of the property, when returned, is a Location object, but when you set it you need to set it to a string. I can add a SetLocation method that does this.

[mattleibow]

Or, you can add a method:

[ScriptSkip]
public static Location FromUrl(string url)
{
    return null;
}

so that we can do something like this:

Window.Location = Location.FromUrl("www.google.com");

The [ScriptSkip] attribute changes it to be:

window.location = "www.google.com"

[erik-kallen]

I'm not too happy about this model because it would also allow you to do

var l = Location.FromUrl("www.google.com/?q=abc");
string query = l.query;

[mattleibow]

What about this:

Window.Location.Assign("www.google.com");

it exists

[erik-kallen]

Still the same modelling problem. What should this do:

var l = Window.Location;
l.Assign('www.google.com')

[mattleibow]

It seems to work fine. Both will take you to Google.

[erik-kallen]

Depends on how you implement the method. The possibilities are:

[InlineCode("window.location = {url}")] Assign(string url)

which seems wrong to me (affecting static state in an instance method), and

[InlineCode("{this} = {url}")] Assign(string url)

which looks better, but obviously doesn't work in many cases.

[mattleibow]

It already exists in the Location object.
And, this is how the JS works now:

var loc = window.location;
loc.assign('http://www.google.com');

If you want to do a C# logic, how will this work?
Updating location (or loc in this case) still navigates the page.

[erik-kallen]

Sorry, I have misunderstood everything. I thought you meant a new method, but now I see that it is already there. I don't know the entire DOM API.

[erik-kallen]

Added Window.SetLocation in 1.3.0