TypeError: get() takes exactly 3 arguments (2 given) about postgres-formula

[YetAnotherMinion]

probably wants a default argument, which in this case would be

{%- if not salt.get('postgres.user_create', False) %}

[vutny]

@fcrozat Thanks for you report.

I've tested the code with Salt 2016.3.4 and 2016.11.1 many times and it always works fine for me. Maybe it is related to particular jinja module version installed...

Try to replace the line with the following:

{%- if 'postgres.user_create' not in salt.keys() %}

I hope this will help. If so, we update the code accordingly.

[fcrozat]

changing to {%- if not salt.get('postgres.user_create', False) %} works fine.

other proposed fix ( %- if 'postgres.user_create' not in salt.keys() %} )doesn't work:

• Rendering SLS 'base:postgres.manage' failed: Jinja error: 'FunctionWrapper' object has no attribute 'call'
  Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/salt/utils/templates.py", line 368, in render_jinja_tmpl
  output = template.render(**decoded_context)
  File "/usr/lib/python2.7/site-packages/jinja2/environment.py", line 989, in render
  return self.environment.handle_exception(exc_info, True)
  File "/usr/lib/python2.7/site-packages/jinja2/environment.py", line 754, in handle_exception
  reraise(exc_type, exc_value, tb)
  File "", line 5, in top-level template code
  AttributeError: 'FunctionWrapper' object has no attribute 'call'

  ; line 5
  
  ---
  {%- from "postgres/map.jinja" import postgres with context -%}
  {%- from "postgres/macros.jinja" import format_state with context -%}
  
  {# }{%- if not salt.get('postgres.user_create') %} #}
  {%- if 'postgres.user_create' not in salt.keys() %}    <======================
  
  # Salt states for managing PostgreSQL is not available,
  # need to provision client binaries first
  
  include:
  [...]
  ---
  

[vutny]

@fcrozat Thanks a lot for testing.
This is very interesting, it looks like ordinary Python methods cannot be reliably used for special Jinja objects such as salt, at least in your case. And I think the get() method cannot be fully trusted here to do the job I thought it was supposed to do.

Please, could you try the last one code snippet since only you are able to reproduce the issue?
Check this out if it would work:

{%- if salt['postgres.user_create']|default(none) is not callable %}

I assume this is the safest check for the exec module function present (and actually is a function) in the state run scope.

Thanks again for your involvement.

[fcrozat]

I can confirm the latest proposed fix works fine here.

[vutny]

Cool! That was very helpful, @fcrozat. Soon I will come up with a PR to fix this and other similar calls to the salt object across the formula.

[vutny]

I have submitted PR #150 to address this issue.

[vutny]

@fcrozat PR #150 has been merged. I think this issue could be closed. Thanks for your participation!

[vutny]

@javierbertoli Since this is already resolved, please close it out. Thanks!