GithubHelp home page GithubHelp logo

Last pixel is black about astro8-computer HOT 3 CLOSED

sam-astro avatar sam-astro commented on August 22, 2024
Last pixel is black

from astro8-computer.

Comments (3)

sam-astro avatar sam-astro commented on August 22, 2024 1

Fixed in the dev branch

from astro8-computer.

maramowicz avatar maramowicz commented on August 22, 2024

I think I finded a problem:
For example ADD if result equals/is higher than 65534 subtracting 65534:
562: if (bus >= 65534)
But if code want draw pixels, its checking up to 65534:
688: if (pixelRamIndex >= 65535) { pixelRamIndex = 61439;
That means is not possible to set int higher than 65533, so its not possible to set 65534 address.

Edit: I'm changed all 65534 to 65535 and everything works correctly so why they are changed? 2^16 = 65536 and if we must include 0 then range is from 0 to 65535.
Maybe I'm wrong, but doesn't this need to be corrected to if (bus >= 65536)?
I think:
65534 is in range
65535 in in range too
65536 is out of range

from astro8-computer.

sam-astro avatar sam-astro commented on August 22, 2024

Thanks I'll fix this, I accidentally thought 65525 was exclusive haha

from astro8-computer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.