GithubHelp home page GithubHelp logo

Please add Montenegro about country-json HOT 11 CLOSED

samayo avatar samayo commented on August 17, 2024
Please add Montenegro

from country-json.

Comments (11)

samayo avatar samayo commented on August 17, 2024 1

I will add this, thanks for the contribution. However, in-order to add it, I must also include an entry to all the other files (population, iso-codes, flags) otherwise the list of countries in all files will be out of sync. I will add you PR in the next major version.

Thanks for your contribution

from country-json.

samayo avatar samayo commented on August 17, 2024 1

Hi Kidilowski, I have reopened the issue. Thanks for the contribution. The Geo-coordinates is just the latitude/longitude for the country, which is: 42.7087° N, 19.3744° E (you can google it) I see only some files have changed but all of them need to have the country and value, I will check from my laptop later and the flag is ok.

Thanks, I will check and get back to you

As for the PR

from country-json.

a1764879 avatar a1764879 commented on August 17, 2024 1

Done 👍

from country-json.

samayo avatar samayo commented on August 17, 2024 1

@kidilowski Thanks for your help a lot!!! I have merged it to master, and I will tag a new release soon

from country-json.

samayo avatar samayo commented on August 17, 2024

@neacsugeorge I will add it, thanks for the info. If you want, you can also send a PR and I will merge it.

from country-json.

a1764879 avatar a1764879 commented on August 17, 2024

Made the changes and created a pull request #136

from country-json.

a1764879 avatar a1764879 commented on August 17, 2024

@samayo should I add the entry to the other files?
Montenegro in (population, iso-codes, flags) ?

from country-json.

samayo avatar samayo commented on August 17, 2024

Yes, that would be very helpful

from country-json.

a1764879 avatar a1764879 commented on August 17, 2024

hi @samayo
I'll be giving a pull request shortly.
For the flag, I've used https://base64.guru/converter/encode/image/svg to convert the SVG to the base64, could you just make sure it's correct?
Also, I didn't quite understand the info to be added in the geo-cordinates.json, so if you tell me from where to get those, I'll do that as well

Also, reopen the issue if you can so that I can assign it to myself. Thanks

from country-json.

a1764879 avatar a1764879 commented on August 17, 2024

Hi @samayo
I did check for the coordinates, but in the JSON file, it is given as:
{ "country": "Afghanistan", "north": "38.4834", "south": "29.3775", "west": "60.4784", "east": "74.8794" }
From the NE values from google, we will get just two values.
Also, I will check if there are any files with the country name to be updated. Some of them already had Montenegro in it.

from country-json.

samayo avatar samayo commented on August 17, 2024

Thanks. For now use the North and East, then I will review all the changes and merge them

from country-json.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.