Comments (7)
I don't have much access than you do I think. I'm just a compulsive code reviewer. That's why you see me active.
You just have to fork the repository, push a branch on it, then open a PR mentioning the issue you want to fix.
I can review a PR if you open one.
from lo.
@ccoVeille by seeing your code reviews, I was amazed at how much good you are doing. I would love to chat with you one day. Can you also review my PR?
Thank you.
from lo.
you are nice, thanks.
You can join the slack workspace of the gophers. You will find the link on my GitHub profile. So we can talk there
Edit: here is the link https://gophers.slack.com/team/U03FE6TMKPX
from lo.
Hey @samber I want to add a PR to resolve this issue. Can I get access to adding a PR for this issue ??
Also, I can see the Test of Keys is incorrect as it sorts the keys before asserting them, but there is no sort in the Keys function. I will also fix them.
from lo.
@ccoVeille I want to be a contributor. Can you help me to get access? I can fix this issue and some other open issues.
Thank you. 😊
from lo.
Related Issues (20)
- Why Async doesn't close a chan? HOT 1
- propose: Add First() on slice, empty to return nil HOT 3
- Chunk has memory leak
- Slight performance boost on PickByKeys / OmitByKeys
- Add .Get() to Tuple family as alias for .Unpack() to match samber/mo
- Cancelable concurrent tasks HOT 1
- Proposal: considering a new type of Group: a key mapper to a bunch of values, for extend map structure
- Proposal: Use generics for underling types
- propose: Add distinctByKey() on slice,return slince
- Suggestion: Add a sorting method by a certain type to slice and return the slice
- Error: could not resolve parametric type of accumulator: could not resolve interface type HOT 1
- Proposal: Helpers for combine function and tuple HOT 3
- TYPO: Maybe a typo in Readme.md HOT 4
- proposal: Another PickByKeys that ouputs a slice
- How to lazy evaluate for the first return value of FilterMap HOT 1
- ForEachWhile method does not exist HOT 1
- Chunk: memory safety HOT 5
- breaking changes to Last() in 1.42.0 HOT 1
- Add Nillable function
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lo.